jenkins-bot has submitted this change and it was merged.
Change subject: Record bytes change
......................................................................
Record bytes change
Note the bytes changed by the first revision are not available
and since we throw away bot edits we can't tell the total amount of
bytes changed by all users.
Thus, this number is not as accurate as it could be but accurate enough.
Bug: T145554
Change-Id: I04ba6e57e8e02917ea48388346524ed4a08498bd
---
M lib/processor.js
M test/features/lib/processor.js
2 files changed, 8 insertions(+), 4 deletions(-)
Approvals:
Pmiazga: Looks good to me, but someone else must approve
Mobrovac: Looks good to me, but someone else must approve
Jhobs: Looks good to me, but someone else must approve
Jhernandez: Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/processor.js b/lib/processor.js
index 383e561..8c7edab 100644
--- a/lib/processor.js
+++ b/lib/processor.js
@@ -96,6 +96,7 @@
edits: 1,
from: ts,
updated: ts,
+ rev_len: edit.rev_len,
anonEdits: 0,
contributors: {
total: 0,
@@ -124,6 +125,7 @@
if (contributors.names[username].edits >
contributors.names[contributors.main].edits) {
contributors.main = username;
}
+ pages[id].bytes = edit.rev_len - pages[id].rev_len;
pages[id].bias = contributors.names[contributors.main].edits /
pages[id].edits;
}
}
diff --git a/test/features/lib/processor.js b/test/features/lib/processor.js
index 5e7f8a3..c471831 100644
--- a/test/features/lib/processor.js
+++ b/test/features/lib/processor.js
@@ -37,7 +37,7 @@
page_id: 3
};
-function edit( id, username, ts, ns, isBot ) {
+function edit( id, username, ts, ns, isBot, data ) {
var performer = {
user_groups: ["*"],
user_is_bot: isBot,
@@ -47,7 +47,7 @@
if ( username.indexOf( '.' ) === -1 ) {
performer.user_id = 1;
}
- return {
+ return Object.assign( {
comment: '',
meta: { topic: "mediawiki.revision-create" },
page_id: id,
@@ -59,14 +59,14 @@
rev_parent_id: 4,
rev_minor_edit: false,
rev_timestamp: ts
- };
+ }, data );
}
describe('processor - series of events', function() {
processor.reset();
processor.process( edit( 1, 'Jon', '2016-11-15T18:00:55+00:00' ) );
processor.process( edit( 1, 'Corey', '2016-11-15T18:02:55+00:00' ) );
- processor.process( edit( 1, 'Bernd', '2016-11-15T18:03:55+00:00' ) );
+ processor.process( edit( 1, 'Bernd', '2016-11-15T18:03:55+00:00', 0,
false, { rev_len: 600 } ) );
processor.process( edit( 2, 'Talker', '2016-11-15T18:03:55+00:00', 1 ) );
processor.process( edit( 1, 'Bot', '2016-11-15T18:03:55+00:00', 0, true )
);
@@ -75,6 +75,8 @@
assert.ok( pages.length === 1, 'Pages with same name are combined into
single page' );
assert.ok( pages[0].edits === 3, 'Edits are counted for all non-bot
edits' );
assert.ok( pages[0].title === 'Foo', 'Title is present' );
+ assert.ok( pages[0].bytes === 400,
+ 'Bytes are calculated based on the rev_len of the first edit and
last' );
assert.ok( pages[0].updated.toISOString() ===
'2016-11-15T18:03:55.000Z',
'Updated is timestamp of last edit' );
assert.ok( pages[0].from.toISOString() === '2016-11-15T18:00:55.000Z',
--
To view, visit https://gerrit.wikimedia.org/r/323324
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I04ba6e57e8e02917ea48388346524ed4a08498bd
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/services/trending-edits
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Jhernandez <jhernan...@wikimedia.org>
Gerrit-Reviewer: Jhobs <jhob...@wikimedia.org>
Gerrit-Reviewer: Mobrovac <mobro...@wikimedia.org>
Gerrit-Reviewer: Pmiazga <pmia...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
