BryanDavis has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/325431

Change subject: jsub: Fix #!... to actually work
......................................................................

jsub: Fix #!... to actually work

Follow up to a53fc1a2dfbf that should actually work. There is no posix
standard for processing #!... lines and my prior attempt fails miserably
on Ubuntu/Linux. The runtime behavior on most (all?) Linux versions is
to split the line on the first whitespace and treat the two parts as the
path to an interpreter and a single argument to pass it. This means that
"/usr/bin/env python2 -E -s" is parsed as ("/usr/bin/env", "python2 -E
-s"). /usr/bin/env then looks for an interpreter named 'python2 -E -s'
and fails for fairly obvious reasons.

Since the busted deb version has never been built and deployed we don't
need a version bump for the package.

Bug: T147350
Change-Id: Ia0e88d9102f5f1df6b32396913077a72833d8f62
---
M jobutils/bin/jsub
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/labs/toollabs 
refs/changes/31/325431/1

diff --git a/jobutils/bin/jsub b/jobutils/bin/jsub
index 3385b4e..af8d85a 100755
--- a/jobutils/bin/jsub
+++ b/jobutils/bin/jsub
@@ -1,4 +1,4 @@
-#!/usr/bin/env python2 -E -s
+#!/usr/bin/python2 -Es
 # -*- coding: utf-8 -*-
 #
 # Submit a job to the job grid.

-- 
To view, visit https://gerrit.wikimedia.org/r/325431
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia0e88d9102f5f1df6b32396913077a72833d8f62
Gerrit-PatchSet: 1
Gerrit-Project: labs/toollabs
Gerrit-Branch: master
Gerrit-Owner: BryanDavis <bda...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to