Daniel Werner has submitted this change and it was merged. Change subject: (bug 44665) start/stopEditing events for claimview widget ......................................................................
(bug 44665) start/stopEditing events for claimview widget This change set implements startEditing and stopEditing events in the claimview widget which required some refactoring in claimlistview/listview widgets. Since there is no point in highlighting the main snak's property when adding/editing a reference, this change set removes the highlighting as well. - patch set 3: Fixed behavior when canceling and reverted changes of patch set 2 since these were not implemented correctly. Change-Id: Ibc92742cbca2a79af5567b906b3801ca6e52b183 --- M lib/resources/jquery.wikibase/jquery.wikibase.claimlistview.js M lib/resources/jquery.wikibase/jquery.wikibase.claimview.js M lib/resources/jquery.wikibase/jquery.wikibase.entityview.js M lib/resources/jquery.wikibase/jquery.wikibase.listview.js M lib/resources/wikibase.css M selenium/lib/modules/statement_module.rb 6 files changed, 441 insertions(+), 237 deletions(-) Approvals: Daniel Werner: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/47842 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc92742cbca2a79af5567b906b3801ca6e52b183 Gerrit-PatchSet: 5 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Henning Snater <henning.sna...@wikimedia.de> Gerrit-Reviewer: Daniel Werner <daniel.wer...@wikimedia.de> Gerrit-Reviewer: Henning Snater <henning.sna...@wikimedia.de> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
