Yuvipanda has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/325901 )
Change subject: paws_internal: Allow ops / statistics-privatedata-users
......................................................................
paws_internal: Allow ops / statistics-privatedata-users
Change-Id: Ib2e65e7a2086c8618210ad213fa943b453997871
---
M modules/jupyterhub/files/jupyterhub_config.py
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/01/325901/1
diff --git a/modules/jupyterhub/files/jupyterhub_config.py
b/modules/jupyterhub/files/jupyterhub_config.py
index 11e511d..1fc7a1e 100644
--- a/modules/jupyterhub/files/jupyterhub_config.py
+++ b/modules/jupyterhub/files/jupyterhub_config.py
@@ -108,8 +108,10 @@
@gen.coroutine
def authenticate(self, handler, data):
username = data['username']
- # FIXME: Parameterize this groupname
- if username not in grp.getgrnam('researchers').gr_mem:
+ allowed_groups = ['researchers', 'statistics-privatedata-users', 'ops']
+ if not any([
+ username not in grp.getgrnam(group).gr_mem
+ for group in allowed_groups]):
self.log.warn('User %s not in researchers group' % username)
return None
return (yield super().authenticate(handler, data))
--
To view, visit https://gerrit.wikimedia.org/r/325901
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib2e65e7a2086c8618210ad213fa943b453997871
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Yuvipanda <yuvipa...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
