Pwirth has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/325950 )
Change subject: Ext.view.Table: buffered store issue fixed ...................................................................... Ext.view.Table: buffered store issue fixed Bugfix for ERM5046. NEEDS MERGE TO MASTER AND REL1_27 Change-Id: I34dd86d231341146fc5cb2f1498001107cfd80c2 --- M resources/bluespice.extjs/bluespice.extjs.js 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BlueSpiceFoundation refs/changes/50/325950/1 diff --git a/resources/bluespice.extjs/bluespice.extjs.js b/resources/bluespice.extjs/bluespice.extjs.js index 14a881c..d2bdfc9 100755 --- a/resources/bluespice.extjs/bluespice.extjs.js +++ b/resources/bluespice.extjs/bluespice.extjs.js @@ -79,13 +79,19 @@ * with an "Ext.grid.feature.Grouping" and the user has collapsed one or * more groups, then in the "handler"-callback of an * "Ext.grid.column.Action" the passed record/rowIndex will be wrong! - * This bug got probably fixed in version "4.2.2.1144", wich is + * This bug got probably fixed in version "4.2.2.1144", which is * unfortunately not available for non-support-subscribers of Sencha Inc. * Therefore we implement this bugfix here and wait for a future update. * See also https://www.sencha.com/forum/showthread.php?264961-Grid-Grouping-Bug&p=973054&viewfull=1#post973054 + * + * ATTENTION: This implementation has issues with buffered stores! Therefore we fall back to base class + * functionality when a store is buffered. This means, both, buffering and grouping will not work together. */ Ext.override( Ext.view.Table, { getRecord: function ( node ) { + if( this.dataSource.buffered ) { + return this.callParent( arguments ); + } node = this.getNode( node ); if ( node ) { return this.dataSource.data.get( @@ -94,6 +100,9 @@ } }, indexInStore: function ( node ) { + if( this.dataSource.buffered ) { + return this.callParent( arguments ); + } node = this.getNode( node, true ); if ( !node && node !== 0 ) { return -1; -- To view, visit https://gerrit.wikimedia.org/r/325950 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I34dd86d231341146fc5cb2f1498001107cfd80c2 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/BlueSpiceFoundation Gerrit-Branch: REL1_27 Gerrit-Owner: Pwirth <wi...@hallowelt.biz> Gerrit-Reviewer: Robert Vogel <vo...@hallowelt.biz> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits