Niedzielski has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/326054 )
Change subject: Hygiene: move lint rules to lint config ...................................................................... Hygiene: move lint rules to lint config Also exclude the Facebook directory from all linting. Note: some linting is inconsistent between Android Studio and Gradle: https://code.google.com/p/android/issues/detail?id=191631 Change-Id: Ibf2365b4ef905437e7aab85559d3ef6a73967756 --- M app/build.gradle M app/lint.xml 2 files changed, 11 insertions(+), 8 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia refs/changes/54/326054/1 diff --git a/app/build.gradle b/app/build.gradle index 965b455..9a7e498 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -128,14 +128,6 @@ } } - // while we still have lint errors; remove once those are fixed - lintOptions { - disable 'MissingTranslation' - disable 'InvalidPackage' // required by Butter Knife - warning 'MissingQuantity' - warning 'ImpliedQuantity' - } - packagingOptions { exclude 'META-INF/services/javax.annotation.processing.Processor' // required by Butter Knife diff --git a/app/lint.xml b/app/lint.xml index b58940a..1f7c745 100644 --- a/app/lint.xml +++ b/app/lint.xml @@ -18,4 +18,15 @@ <ignore regexp="crash_report_dialog_[a-z_]+" /> <ignore regexp="tool_tip_arrow_[updown]+" /> </issue> + + <issue id="all"> + <ignore path="java/com/facebook" /> + </issue> + + <issue id="InvalidPackage" severity="ignore" /> <!-- Required by Butter Knife --> + + <issue id="MissingTranslation" severity="ignore" /> + <issue id="UnusedQuantity" severity="ignore" /> + <issue id="MissingQuantity" severity="warning" /> + <issue id="ImpliedQuantity" severity="warning" /> </lint> \ No newline at end of file -- To view, visit https://gerrit.wikimedia.org/r/326054 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibf2365b4ef905437e7aab85559d3ef6a73967756 Gerrit-PatchSet: 1 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: Niedzielski <sniedziel...@wikimedia.org> Gerrit-Reviewer: Sniedzielski <sniedziel...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
