jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/326188 )
Change subject: Follow-up e8dd1f43fb169: fix JS error when $wgTranslateNumerals is false ...................................................................... Follow-up e8dd1f43fb169: fix JS error when $wgTranslateNumerals is false Bug: T152800 Change-Id: I99c341168dada063876a66689d68e0b9adf7f09a (cherry picked from commit e2834bacbde682e4da510927879fd54da056a2e8) --- M resources/src/mediawiki.language/mediawiki.language.numbers.js 1 file changed, 10 insertions(+), 6 deletions(-) Approvals: Catrope: Looks good to me, approved jenkins-bot: Verified diff --git a/resources/src/mediawiki.language/mediawiki.language.numbers.js b/resources/src/mediawiki.language/mediawiki.language.numbers.js index 10ceecc..83277cb 100644 --- a/resources/src/mediawiki.language/mediawiki.language.numbers.js +++ b/resources/src/mediawiki.language/mediawiki.language.numbers.js @@ -223,13 +223,17 @@ numberString = mw.language.commafy( num, pattern ); } - convertedNumber = ''; - for ( i = 0; i < numberString.length; i++ ) { - if ( transformTable.hasOwnProperty( numberString[ i ] ) ) { - convertedNumber += transformTable[ numberString[ i ] ]; - } else { - convertedNumber += numberString[ i ]; + if ( transformTable ) { + convertedNumber = ''; + for ( i = 0; i < numberString.length; i++ ) { + if ( transformTable.hasOwnProperty( numberString[ i ] ) ) { + convertedNumber += transformTable[ numberString[ i ] ]; + } else { + convertedNumber += numberString[ i ]; + } } + } else { + convertedNumber = numberString; } if ( integer ) { -- To view, visit https://gerrit.wikimedia.org/r/326188 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I99c341168dada063876a66689d68e0b9adf7f09a Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: wmf/1.29.0-wmf.5 Gerrit-Owner: Jforrester <jforres...@wikimedia.org> Gerrit-Reviewer: Catrope <r...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits