jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/326853 )
Change subject: Revert special null treatment ...................................................................... Revert special null treatment Graph wouldn't understand "undefined", so we need to keep "null" whenever the value is missing. Bug: T152753 Change-Id: Ib5bf956b32e6dfda322f574d99819e53136084fd --- M lib/graph2.compiled.js 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: MaxSem: Looks good to me, approved jenkins-bot: Verified diff --git a/lib/graph2.compiled.js b/lib/graph2.compiled.js index 10c0c54..14d7770 100644 --- a/lib/graph2.compiled.js +++ b/lib/graph2.compiled.js @@ -553,9 +553,8 @@ data.data = data.data.map(function(v) { var row = {}, i; for (i = 0; i < fields.length; i++) { - if (v[i] !== null) { - row[fields[i]] = v[i]; - } + // Need to copy nulls too -- Vega has no easy way to test for undefined + row[fields[i]] = v[i]; } return row; }); -- To view, visit https://gerrit.wikimedia.org/r/326853 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib5bf956b32e6dfda322f574d99819e53136084fd Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Graph Gerrit-Branch: master Gerrit-Owner: Yurik <yu...@wikimedia.org> Gerrit-Reviewer: MaxSem <maxsem.w...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits