Andrew Bogott has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/326887 )

Change subject: Keystone:  Incorrect role assignment is critical
......................................................................

Keystone:  Incorrect role assignment is critical

This is a possible security concern, so make this
elligible for paging.

Bug: T152708
Change-Id: I5550f6e459d61c15d65fe1b74ed5a21d7a764a39
---
M modules/icinga/files/check_keystone_roles
1 file changed, 1 insertion(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/87/326887/1

diff --git a/modules/icinga/files/check_keystone_roles 
b/modules/icinga/files/check_keystone_roles
index d183414..2023586 100755
--- a/modules/icinga/files/check_keystone_roles
+++ b/modules/icinga/files/check_keystone_roles
@@ -43,7 +43,7 @@
 
             rstring = ("In %s, user %s should have roles %s but has %s" %
                        (project, user, requiredroles, namelist))
-            return (WARNING, rstring)
+            return (CRITICAL, rstring)
 
     if all_projects:
         allprojects = clients.allprojects()
@@ -92,5 +92,3 @@
 
 if __name__ == '__main__':
     main()
-
-check_roles('novaadmin', ['projectadmin', 'user'])

-- 
To view, visit https://gerrit.wikimedia.org/r/326887
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5550f6e459d61c15d65fe1b74ed5a21d7a764a39
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Andrew Bogott <abog...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to