Pwirth has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/326972 )
Change subject: BSReview: Yearly mail fixes
......................................................................
BSReview: Yearly mail fixes
=> Needs cherry-pick to REL1_27 and master
Change-Id: I7e04f3b71e8c0bba7b7ef435da42cf21328e27c5
(cherry picked from commit f8e5a9821a8cab87af7be878607edb5ec56e9bfd)
---
M Review/Review.class.php
1 file changed, 9 insertions(+), 1 deletion(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BlueSpiceExtensions
refs/changes/72/326972/1
diff --git a/Review/Review.class.php b/Review/Review.class.php
index b44de8f..8b493e2 100644
--- a/Review/Review.class.php
+++ b/Review/Review.class.php
@@ -1381,6 +1381,9 @@
);
}
} else {
+ if ( $oReviewProcess->isSequential() &&
!$oReviewProcess->isFinished() ) {
+ $oReview->emailNotifyNextUsers( $oReviewProcess
);
+ }
BSNotifications::notify(
'bs-review-accept',
$oUser,
@@ -1413,7 +1416,12 @@
// Let flagged revision know that it's all goooooood (or not
approved)
$bResult = true;
wfRunHooks( 'checkPageIsReviewable', array( $oTitle, &$bResult
) );
- if ( $bResult && $oReviewProcess->isFinished() == 'status' &&
$oUser->isAllowed( 'review' ) ) {
+ //all autorevie related stuff should be moved to
FlaggedRevsConnector
+ //send autoflag mail only when it is acitvated
+ $bAutoReview = class_exists( 'FlaggedRevsConnector' )
+ &&
BsConfig::get('MW::FlaggedRevsConnector::autoReview') === true
+ ;
+ if ( $bResult && $oReviewProcess->isFinished() == 'status' &&
$bAutoReview ) {
BSNotifications::notify(
'bs-review-finish-and-autoflag',
$oUser,
--
To view, visit https://gerrit.wikimedia.org/r/326972
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7e04f3b71e8c0bba7b7ef435da42cf21328e27c5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceExtensions
Gerrit-Branch: master
Gerrit-Owner: Pwirth <wi...@hallowelt.biz>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
