Ema has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/327511 )

Change subject: varnish cachestats.py: strip final newline
......................................................................


varnish cachestats.py: strip final newline

Get rid of the trailing newline before passing self.cmd's output
handle_record.

Bug: T151643
Change-Id: I91ba38dcaf6b888f82027d0e4f27d03ee4377529
---
M modules/varnish/files/cachestats.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Ema: Verified; Looks good to me, approved
  Volans: Looks good to me, but someone else must approve



diff --git a/modules/varnish/files/cachestats.py 
b/modules/varnish/files/cachestats.py
index 3650765..1bf7be8 100644
--- a/modules/varnish/files/cachestats.py
+++ b/modules/varnish/files/cachestats.py
@@ -106,7 +106,7 @@
 
         try:
             while True:
-                line = p.stdout.readline()
+                line = p.stdout.readline().rstrip('\n')
                 self.handle_record(line)
         except KeyboardInterrupt:
             os.waitpid(p.pid, 0)

-- 
To view, visit https://gerrit.wikimedia.org/r/327511
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I91ba38dcaf6b888f82027d0e4f27d03ee4377529
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ema <e...@wikimedia.org>
Gerrit-Reviewer: BBlack <bbl...@wikimedia.org>
Gerrit-Reviewer: Elukey <ltosc...@wikimedia.org>
Gerrit-Reviewer: Ema <e...@wikimedia.org>
Gerrit-Reviewer: Volans <rcocci...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to