EBernhardson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/327569 )
Change subject: Correct DatabaseSqlite::unionQueries annotation ...................................................................... Correct DatabaseSqlite::unionQueries annotation The annotation was claiming string, but it's very obvious from the usage the it should be string[]. Change-Id: I99849a338971590ca68dfb175b2458ad5ebc0df2 --- M includes/libs/rdbms/database/DatabaseSqlite.php M tests/phan/config.php 2 files changed, 1 insertion(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/69/327569/1 diff --git a/includes/libs/rdbms/database/DatabaseSqlite.php b/includes/libs/rdbms/database/DatabaseSqlite.php index a06aad2..a4b2df0 100644 --- a/includes/libs/rdbms/database/DatabaseSqlite.php +++ b/includes/libs/rdbms/database/DatabaseSqlite.php @@ -665,7 +665,7 @@ } /** - * @param string $sqls + * @param string[] $sqls * @param bool $all Whether to "UNION ALL" or not * @return string */ diff --git a/tests/phan/config.php b/tests/phan/config.php index 7fc069d..fba01af 100644 --- a/tests/phan/config.php +++ b/tests/phan/config.php @@ -305,8 +305,6 @@ "PhanParamSignatureMismatch", // approximate error count: 7 "PhanParamSignatureMismatchInternal", - // approximate error count: 1 - "PhanParamSpecial1", // approximate error count: 2 "PhanParamTooFew", // approximate error count: 308 -- To view, visit https://gerrit.wikimedia.org/r/327569 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I99849a338971590ca68dfb175b2458ad5ebc0df2 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: EBernhardson <ebernhard...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits