Dzahn has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/304476 )
Change subject: hhvm::admin: Restrict to domain networks
......................................................................
hhvm::admin: Restrict to domain networks
On production systems the port is only accessed from production hosts,
use DOMAIN_NETWORKS to allow allow it to be used in labs.
Change-Id: I856d9f7630c9e65ee46e0d2c60cb1c565c3a0366
---
M modules/hhvm/manifests/admin.pp
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Giuseppe Lavagetto: Looks good to me, approved
jenkins-bot: Verified
Dzahn: Looks good to me, but someone else must approve
diff --git a/modules/hhvm/manifests/admin.pp b/modules/hhvm/manifests/admin.pp
index deeb3f1..0358c51 100644
--- a/modules/hhvm/manifests/admin.pp
+++ b/modules/hhvm/manifests/admin.pp
@@ -31,6 +31,6 @@
ferm::service { 'hhvm_admin':
proto => 'tcp',
port => $port,
- srange => '$INTERNAL',
+ srange => '$DOMAIN_NETWORKS',
}
}
--
To view, visit https://gerrit.wikimedia.org/r/304476
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I856d9f7630c9e65ee46e0d2c60cb1c565c3a0366
Gerrit-PatchSet: 4
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Muehlenhoff <[email protected]>
Gerrit-Reviewer: Alexandros Kosiaris <[email protected]>
Gerrit-Reviewer: Dzahn <[email protected]>
Gerrit-Reviewer: Elukey <[email protected]>
Gerrit-Reviewer: Giuseppe Lavagetto <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
