Ejegg has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/327843 )
Change subject: Clean up some ununsed stuff ...................................................................... Clean up some ununsed stuff Change-Id: I10cf89c8980345f667e64ae4a6d3991021bcffcd --- M src/components/widgets/fraud-gauge/fraud-gauge.html M src/components/widgets/fraud-gauge/fraud-gauge.js 2 files changed, 0 insertions(+), 20 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/dash refs/changes/43/327843/1 diff --git a/src/components/widgets/fraud-gauge/fraud-gauge.html b/src/components/widgets/fraud-gauge/fraud-gauge.html index b283ba5..9f7736c 100644 --- a/src/components/widgets/fraud-gauge/fraud-gauge.html +++ b/src/components/widgets/fraud-gauge/fraud-gauge.html @@ -84,21 +84,6 @@ <!--Call Date Pickers Component to handle date range--> <date-pickers params="selectedTimePeriod: selectedTimePeriod"></date-pickers> <filters params="change: logStateChange, userChoices: userChoices, metadataRequest: metadataRequest, queryString: filterQueryString" /> - <!--div class="form-group filterPickerForm"> - <label>Filter By:</label><br> - <p class="small text-warning" style="display: inline"><i class="fa fa-lightbulb-o"></i> by default, the result will be "all of the above."</p> - <ul class="filterPickerList nav nav-tabs" id="filterNav" role="tablist" data-bind="foreach: filters"> - <li data-bind="visible: $data.values"> - <input type="checkbox" data-bind="checkedValue: display, checked: $parent.selectedFilters, click: $parent.showSubfilters(display)"><span data-bind="text: display"></span> - <ul class="hide filterPickerList subfilterSubnav" data-bind="attr: {'id': display}, foreach: $data.values"> - <li> - <input type="checkbox" class="filterChoices" data-bind="value: ($parentContext.$data.display + ' eq \'' + $data + '\''), checked: $parents[1].selectedSubFilters"><span data-bind="text: $data"></span> - </li> - </ul> - </li> - </ul> - </div--> - </form> </div> <div class="modal-footer"> diff --git a/src/components/widgets/fraud-gauge/fraud-gauge.js b/src/components/widgets/fraud-gauge/fraud-gauge.js index d2673aa..c0e16e5 100644 --- a/src/components/widgets/fraud-gauge/fraud-gauge.js +++ b/src/components/widgets/fraud-gauge/fraud-gauge.js @@ -43,16 +43,11 @@ self.queryString = ''; self.columnSize = ko.observable('col-lg-' + ( self.config.width || 6 ) + ' fraudGauge'); self.selectedTimePeriod = ko.observable( self.config.timeBreakout || 'Last 15 Minutes'); - self.queryRequest = []; self.gaugeValue = ko.observable(0); - self.queryStringSQL = ko.observable('This widget hasn\'t been set up yet!'); self.greenHighRange = ko.observable( self.config.greenHighRange || 17 ); self.redLowRange = ko.observable( self.config.redLowRange || 68 ); self.configSet = ko.observable(Object.keys(self.config).length > 0); self.gauge = ko.observable(false); - self.showFilterText = ko.computed( function() { - return !( $.isEmptyObject( self.userChoices() ) ); - } ); self.renderPercentRangeChart = function(){ -- To view, visit https://gerrit.wikimedia.org/r/327843 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I10cf89c8980345f667e64ae4a6d3991021bcffcd Gerrit-PatchSet: 1 Gerrit-Project: wikimedia/fundraising/dash Gerrit-Branch: master Gerrit-Owner: Ejegg <eeggles...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits