jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/325799 )

Change subject: Replace deprecated skin's commentBlock function with 
Linker::commentBlock
......................................................................


Replace deprecated skin's commentBlock function with Linker::commentBlock

The function is deprecated here 
https://github.com/wikimedia/mediawiki-debian/blob/6a4a101a0091a8684784156635058a6f532cbfe7/includes/skins/Skin.php#L1567

But i doint know why it was calling SkinVector::

This patch should fix this hopefully.

Bug: T152605
Change-Id: Ifb1b9aa2596b2ae5fa3aede1924da72f6604868f
---
M MassEditRegex.special.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Paladox: Looks good to me, but someone else must approve
  Reedy: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/MassEditRegex.special.php b/MassEditRegex.special.php
index d8b9a6b..8417b6b 100644
--- a/MassEditRegex.special.php
+++ b/MassEditRegex.special.php
@@ -360,7 +360,7 @@
                        Xml::tags( 'div',
                                array( 'class' => 'mw-summary-preview' ),
                                $this->msg( 'summary-preview' )->parse() .
-                                       $this->sk->commentBlock( 
$this->massEditRegex->getSummary() )
+                                       Linker::commentBlock( 
$this->massEditRegex->getSummary() )
                        ) .
                        Xml::closeElement( 'div' ) . // class=editOptions
 

-- 
To view, visit https://gerrit.wikimedia.org/r/325799
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb1b9aa2596b2ae5fa3aede1924da72f6604868f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MassEditRegex
Gerrit-Branch: REL1_28
Gerrit-Owner: Kghbln <kars...@hoffmeyer.info>
Gerrit-Reviewer: Alex Monk <a...@wikimedia.org>
Gerrit-Reviewer: Florianschmidtwelzow <florian.schmidt.stargatewis...@gmail.com>
Gerrit-Reviewer: Kghbln <kars...@hoffmeyer.info>
Gerrit-Reviewer: Legoktm <lego...@member.fsf.org>
Gerrit-Reviewer: Paladox <thomasmulhall...@yahoo.com>
Gerrit-Reviewer: Reedy <re...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to