jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/328411 )
Change subject: ApiQueryWatchlist: Handle empty wltypes ...................................................................... ApiQueryWatchlist: Handle empty wltypes The pre-WatchedItemQueryService code used ApiQueyrBase::addWhereFld() which filters out empty arrays. WatchedItemQueryService doesn't do that. Bug: T153733 Change-Id: I3416b5a05c9751303b5c28a8b6d9cb746a101f73 --- M includes/api/ApiQueryWatchlist.php 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Gergő Tisza: Looks good to me, approved jenkins-bot: Verified diff --git a/includes/api/ApiQueryWatchlist.php b/includes/api/ApiQueryWatchlist.php index 6b5ceb7..3f59751 100644 --- a/includes/api/ApiQueryWatchlist.php +++ b/includes/api/ApiQueryWatchlist.php @@ -151,7 +151,10 @@ if ( !is_null( $params['type'] ) ) { try { - $options['rcTypes'] = RecentChange::parseToRCType( $params['type'] ); + $rcTypes = RecentChange::parseToRCType( $params['type'] ); + if ( $rcTypes ) { + $options['rcTypes'] = $rcTypes; + } } catch ( Exception $e ) { ApiBase::dieDebug( __METHOD__, $e->getMessage() ); } -- To view, visit https://gerrit.wikimedia.org/r/328411 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3416b5a05c9751303b5c28a8b6d9cb746a101f73 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Anomie <bjor...@wikimedia.org> Gerrit-Reviewer: Gergő Tisza <gti...@wikimedia.org> Gerrit-Reviewer: Legoktm <lego...@member.fsf.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits