MtDu has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/329510 )
Change subject: Remove unnecessary doc for doLinkCacheQuery and fix a small typo
......................................................................
Remove unnecessary doc for doLinkCacheQuery and fix a small typo
* It doesn't return anything
Bug: T154233
Change-Id: Iab4262903dd3e22e3ffbd00ca6575ecf6d26b665
---
M includes/Echo/EchoNewsletterUserLocator.php
M includes/content/NewsletterContent.php
2 files changed, 1 insertion(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Newsletter
refs/changes/10/329510/1
diff --git a/includes/Echo/EchoNewsletterUserLocator.php
b/includes/Echo/EchoNewsletterUserLocator.php
index 3e7b814..b70281d 100644
--- a/includes/Echo/EchoNewsletterUserLocator.php
+++ b/includes/Echo/EchoNewsletterUserLocator.php
@@ -5,7 +5,7 @@
* Locate all users subscribed to a newsletter.
*
* @param EchoEvent $event
- * @return User[]|array empty if the newsletter has beend
deleted/invalid
+ * @return User[]|array empty if the newsletter has been deleted/invalid
*/
public static function locateNewsletterSubscribedUsers( EchoEvent
$event ) {
$extra = $event->getExtra();
diff --git a/includes/content/NewsletterContent.php
b/includes/content/NewsletterContent.php
index 10788a2..0f2bb85 100644
--- a/includes/content/NewsletterContent.php
+++ b/includes/content/NewsletterContent.php
@@ -307,8 +307,6 @@
* or not and add them to LinkCache
*
* @param Iterator $users
- *
- * @return string
*/
private function doLinkCacheQuery( Iterator $users ) {
$batch = new LinkBatch();
--
To view, visit https://gerrit.wikimedia.org/r/329510
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iab4262903dd3e22e3ffbd00ca6575ecf6d26b665
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Newsletter
Gerrit-Branch: master
Gerrit-Owner: MtDu <justin.d...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
