BryanDavis has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/329544 )

Change subject: crm::dash: Fix Puppet lint errors
......................................................................

crm::dash: Fix Puppet lint errors

Change-Id: I479c9482b5cd6d40c32cf96790a49bc1b78b149c
(cherry picked from commit 80e627169457d1e98807656c89f7c6c796669a3e)
---
M puppet/modules/crm/manifests/dash.pp
1 file changed, 8 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/vagrant 
refs/changes/44/329544/1

diff --git a/puppet/modules/crm/manifests/dash.pp 
b/puppet/modules/crm/manifests/dash.pp
index 0b4b416..30371c3 100644
--- a/puppet/modules/crm/manifests/dash.pp
+++ b/puppet/modules/crm/manifests/dash.pp
@@ -7,18 +7,18 @@
     require ::npm
 
     # FIXME this should be in hieradata
-    $fundraising_dash_dir = "/vagrant/srv/fundraising-dash"
+    $fundraising_dash_dir = '/vagrant/srv/fundraising-dash'
 
     git::clone { 'wikimedia/fundraising/dash':
         directory => $fundraising_dash_dir
     }
 
-    npm::install { "dash_npm_install":
+    npm::install { 'dash_npm_install':
         directory => $fundraising_dash_dir,
         require   => Git::Clone['wikimedia/fundraising/dash']
     }
 
-    exec { "dash_bower_install":
+    exec { 'dash_bower_install':
         command     => "${fundraising_dash_dir}/node_modules/bower/bin/bower 
install",
         cwd         => $fundraising_dash_dir,
         require     => Npm::Install['dash_npm_install'],
@@ -41,15 +41,15 @@
         ],
     }
 
-    file { "/etc/init/fundraising_dash.conf":
+    file { '/etc/init/fundraising_dash.conf':
         content => template('crm/fundraising_dash.conf.erb'),
     }
 
     service { 'fundraising_dash':
-        enable    => true,
-        provider  => 'upstart',
-        ensure    => running,
-        require   => Exec['dash_schema'],
+        ensure   => running,
+        enable   => true,
+        provider => 'upstart',
+        require  => Exec['dash_schema'],
     }
 
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/329544
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I479c9482b5cd6d40c32cf96790a49bc1b78b149c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/vagrant
Gerrit-Branch: jessie-migration
Gerrit-Owner: BryanDavis <bda...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to