Filip has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/329680 )
Change subject: Newsletter cleanup
......................................................................
Newsletter cleanup
Added docs to some functions, and declared $createNew as instance variable.
Bug: T153906
Change-Id: If5fcee346f9a5177898d254298aeda09ddd7099e
---
M includes/NewsletterEditPage.php
M includes/NewsletterStore.php
2 files changed, 5 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Newsletter
refs/changes/80/329680/1
diff --git a/includes/NewsletterEditPage.php b/includes/NewsletterEditPage.php
index 0532f34..a3a0463 100644
--- a/includes/NewsletterEditPage.php
+++ b/includes/NewsletterEditPage.php
@@ -1,7 +1,7 @@
<?php
class NewsletterEditPage {
-
+ protected $createNew;
protected $context;
protected $readOnly = false;
diff --git a/includes/NewsletterStore.php b/includes/NewsletterStore.php
index 76eccc7..8e86f2c 100644
--- a/includes/NewsletterStore.php
+++ b/includes/NewsletterStore.php
@@ -27,7 +27,9 @@
$this->db = $db;
$this->logger = $logger;
}
-
+ /**
+ * @return NewsletterStore instance of NewsletterStore
+ */
public static function getDefaultInstance(){
if ( !self::$instance ) {
self::$instance = new self(
@@ -198,7 +200,7 @@
/**
* @param int $id
*
- * @return string[]
+ * @return int[]
*/
public function getSubscribersFromID( $id ) {
return $this->db->getSubscribersFromID( $id );
--
To view, visit https://gerrit.wikimedia.org/r/329680
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If5fcee346f9a5177898d254298aeda09ddd7099e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Newsletter
Gerrit-Branch: master
Gerrit-Owner: Filip <r...@protonmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
