MtDu has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/329701 )
Change subject: Replace deprecated attribute "width" with CSS "width" property ...................................................................... Replace deprecated attribute "width" with CSS "width" property The width attribute is deprecated in HTML5. It should use the CSS width property instead. For example, width='100%' should be replaced with style="width: 100%;" Bug: T42211 Change-Id: I34f7819b0615e951c0f433cfbbaff5bcc32784b0 --- M frontend/FlaggablePageView.php 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/FlaggedRevs refs/changes/01/329701/1 diff --git a/frontend/FlaggablePageView.php b/frontend/FlaggablePageView.php index 64941ec..670bfe6 100755 --- a/frontend/FlaggablePageView.php +++ b/frontend/FlaggablePageView.php @@ -828,15 +828,15 @@ $multiNotice . "</td></tr>"; } return - "<table border='0' width='98%' cellpadding='0' cellspacing='4' class='$tableClass'>" . + "<table border='0' cellpadding='0' cellspacing='4' style='width: 98%;' class='$tableClass'>" . "<col class='diff-marker' />" . "<col class='diff-content' />" . "<col class='diff-marker' />" . "<col class='diff-content' />" . "<tr>" . - "<td colspan='2' width='50%' style='text-align: center;' class='diff-otitle'><b>" . + "<td colspan='2' style='text-align: center; width: 50%;' class='diff-otitle'><b>" . $leftStatus . "</b></td>" . - "<td colspan='2' width='50%' style='text-align: center;' class='diff-ntitle'><b>" . + "<td colspan='2' style='text-align: center; width: 50%;' class='diff-ntitle'><b>" . $rightStatus . "</b></td>" . "</tr>" . $multiNotice . @@ -1612,13 +1612,13 @@ if ( $oldRev && $newRev ) { list( $msg, $class ) = self::getDiffRevMsgAndClass( $oldRev, $srev ); $table .= "<table class='fr-diff-ratings'><tr>"; - $table .= "<td width='50%' style='text-align: center;'>"; + $table .= "<td style='text-align: center; width: 50%;'>"; // @todo i18n FIXME: Hard coded brackets $table .= "<span class='$class'>[" . wfMessage( $msg )->escaped() . "]</span>"; list( $msg, $class ) = self::getDiffRevMsgAndClass( $newRev, $srev ); - $table .= "</td><td width='50%' style='text-align: center;'>"; + $table .= "</td><td style='text-align: center; width: 50%';>"; // @todo i18n FIXME: Hard coded brackets $table .= "<span class='$class'>[" . wfMessage( $msg )->escaped() . "]</span>"; -- To view, visit https://gerrit.wikimedia.org/r/329701 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I34f7819b0615e951c0f433cfbbaff5bcc32784b0 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/FlaggedRevs Gerrit-Branch: master Gerrit-Owner: MtDu <justin.d...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits