jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/329657 )
Change subject: Remove serialization test cheat; make tests actually pass
......................................................................
Remove serialization test cheat; make tests actually pass
The author of I1eccd4ef99d764911994d11d747f13ae42919eff is clearly a very shady
character
Change-Id: I69038332adf57ce43edd85930028d337a4946356
---
M tests/dm/ve.dm.Change.test.js
1 file changed, 32 insertions(+), 24 deletions(-)
Approvals:
Esanders: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/dm/ve.dm.Change.test.js b/tests/dm/ve.dm.Change.test.js
index ef67971..53e404e 100644
--- a/tests/dm/ve.dm.Change.test.js
+++ b/tests/dm/ve.dm.Change.test.js
@@ -269,28 +269,34 @@
serialized = {
start: 0,
transactions: [
- [
- { type: 'retain', length: 1 },
- {
- type: 'replace',
- remove: [],
- insert: [ [ 'f', bIndex ] ],
- insertedDataOffset: 0,
- insertedDataLength: 1
- },
- { type: 'retain', length: 4 }
- ],
- [
- { type: 'retain', length: 2 },
- {
- type: 'replace',
- remove: [],
- insert: [ [ 'u', bIndex ] ],
- insertedDataOffset: 0,
- insertedDataLength: 1
- },
- { type: 'retain', length: 4 }
- ]
+ {
+ author: null,
+ operations: [
+ { type: 'retain', length: 1 },
+ {
+ type: 'replace',
+ remove: [],
+ insert: [ [ 'f', bIndex
] ],
+ insertedDataOffset: 0,
+ insertedDataLength: 1
+ },
+ { type: 'retain', length: 4 }
+ ]
+ },
+ {
+ author: null,
+ operations: [
+ { type: 'retain', length: 2 },
+ {
+ type: 'replace',
+ remove: [],
+ insert: [ [ 'u', bIndex
] ],
+ insertedDataOffset: 0,
+ insertedDataLength: 1
+ },
+ { type: 'retain', length: 4 }
+ ]
+ }
],
stores: [
{
@@ -305,7 +311,10 @@
},
hashes: bIndex
},
- {}
+ {
+ hashStore: {},
+ hashes: []
+ }
],
selections: {}
};
@@ -313,7 +322,6 @@
// Fixup second insert
change.transactions[ 1 ].operations[ 2 ].length += 1;
- serialized = change.serialize();
assert.deepEqual( change.serialize(), serialized, 'Serialize' );
assert.deepEqual(
--
To view, visit https://gerrit.wikimedia.org/r/329657
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I69038332adf57ce43edd85930028d337a4946356
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Divec <da...@troi.org>
Gerrit-Reviewer: Esanders <esand...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
