jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/330130 )
Change subject: Use lowercase letters for query string params
......................................................................
Use lowercase letters for query string params
Also remove extdist_submit, as it is unused.
Change-Id: I232cb0402b1e99d3f675966587baf21ee287e3e9
---
M includes/specials/SpecialBaseDistributor.php
M resources/ext.extensiondistributor.special.js
2 files changed, 9 insertions(+), 14 deletions(-)
Approvals:
Addshore: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/specials/SpecialBaseDistributor.php
b/includes/specials/SpecialBaseDistributor.php
index e121666..1a176a0 100644
--- a/includes/specials/SpecialBaseDistributor.php
+++ b/includes/specials/SpecialBaseDistributor.php
@@ -56,8 +56,8 @@
list( $name, $version ) = $parts;
} else {
- $name = $this->getRequest()->getVal( 'extdist_name' );
- $version = $this->getRequest()->getVal(
'extdist_version' );
+ $name = $this->getRequest()->getVal( 'extdistname' );
+ $version = $this->getRequest()->getVal(
'extdistversion' );
}
if ( !$name ) {
@@ -125,13 +125,12 @@
'classes' => [ 'mw-extdist-selector' ],
'infusable' => true,
'options' => $items,
- 'name' => 'extdist_name',
+ 'name' => 'extdistname',
] ) .
// only shown to no-JS users via CSS
new OOUI\ButtonInputWidget( [
'classes' => [ 'mw-extdist-ext-submit' ],
'infusable' => true,
- 'name' => 'extdist_submit',
'label' => $this->msg(
'extdist-submit-extension' )->text(),
'type' => 'submit',
'flags' => [ 'primary', 'progressive' ],
@@ -230,7 +229,7 @@
Xml::openElement( 'form', [
'action' =>
$this->getPageTitle()->getLocalURL(),
'method' => 'GET' ] ) .
- Html::hidden( 'extdist_name', $repoName );
+ Html::hidden( 'extdistname', $repoName );
$options = [];
$selected = 0;
@@ -251,10 +250,9 @@
'infusable' => true,
'options' => $options,
'value' =>
$wgExtDistDefaultSnapshot,
- 'name' => 'extdist_version',
+ 'name' => 'extdistversion',
] ),
new OOUI\ButtonInputWidget( [
- 'name' => 'extdist_submit',
'label' => $this->msg(
'extdist-submit-version' )->text(),
'type' => 'submit',
'flags' => [ 'primary',
'progressive' ],
diff --git a/resources/ext.extensiondistributor.special.js
b/resources/ext.extensiondistributor.special.js
index 92bf73a..fb94936 100644
--- a/resources/ext.extensiondistributor.special.js
+++ b/resources/ext.extensiondistributor.special.js
@@ -104,7 +104,7 @@
classes: [ 'mw-extdist-selector-version' ],
options: options,
value: mw.config.get(
'wgExtDistDefaultSnapshot' ),
- name: 'extdist_version'
+ name: 'extdistversion'
} );
// JS parser doesn't handle \n\n, see T100229
$continue.html( mw.message(
@@ -113,17 +113,14 @@
).parse().replace( /\n\n/g, '<p>' ) );
versionButton = new OO.ui.ButtonInputWidget( {
classes: [ 'mw-extdist-submit-button' ],
- name: 'extdist_submit',
label: mw.msg( 'extdist-submit-version' ),
flags: [ 'primary', 'progressive' ]
} ).on( 'click', function () {
// Redirect to download page:
- //
extdist_name=ExtensionDistributor&extdist_version=master
+ //
extdistname=ExtensionDistributor&extdistversion=master
window.location.href = mw.util.getUrl(
mw.config.get( 'wgPageName' ), {
- /* eslint-disable camelcase */
- extdist_name: selector.getValue(),
- extdist_version:
versionSelector.getValue()
- /* eslint-enable camelcase */
+ extdistname: selector.getValue(),
+ extdistversion:
versionSelector.getValue()
} );
} );
versionField = new OO.ui.ActionFieldLayout(
versionSelector, versionButton, {
--
To view, visit https://gerrit.wikimedia.org/r/330130
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I232cb0402b1e99d3f675966587baf21ee287e3e9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ExtensionDistributor
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>
Gerrit-Reviewer: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
