Umherirrender has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330167 )
Change subject: Use strlen to get length of string
......................................................................
Use strlen to get length of string
Count is used for arrays
Change-Id: Ica9871d020bcb8db0f9149aaf3f838c93af54327
---
M frontend/RejectConfirmationFormUI.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/FlaggedRevs
refs/changes/67/330167/1
diff --git a/frontend/RejectConfirmationFormUI.php
b/frontend/RejectConfirmationFormUI.php
index 025b144..4637193 100755
--- a/frontend/RejectConfirmationFormUI.php
+++ b/frontend/RejectConfirmationFormUI.php
@@ -120,7 +120,7 @@
)->numParams( count( $rejectAuthors )
)->inContentLanguage()->text();
// If the message is too big, then fallback to the shorter one
$colonSeparator = wfMessage( 'colon-separator' )->text();
- $maxLen = 255 - count( $colonSeparator ) - count( $comment );
+ $maxLen = 255 - strlen( $colonSeparator ) - strlen( $comment );
if ( strlen( $defaultSummary ) > $maxLen ) {
$msg = $newRev->isCurrent()
? 'revreview-reject-summary-cur-short'
--
To view, visit https://gerrit.wikimedia.org/r/330167
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ica9871d020bcb8db0f9149aaf3f838c93af54327
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/FlaggedRevs
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <umherirrender_de...@web.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
