jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/330074 )
Change subject: Cast stashed values to integer
......................................................................
Cast stashed values to integer
Stash may return false if the value hasn't been set yet. This basically
means 'zero'.
Steps to reproduce: create a new filter and open it. If it doesn't have
any hits, the second message parameter is missing instead of being '0'.
Change-Id: I8f240dd87664ec99a98b843f9e5c4c8c9eed0532
---
M Views/AbuseFilterViewEdit.php
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
Addshore: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/Views/AbuseFilterViewEdit.php b/Views/AbuseFilterViewEdit.php
index b47ad13..ca25b6a 100644
--- a/Views/AbuseFilterViewEdit.php
+++ b/Views/AbuseFilterViewEdit.php
@@ -389,8 +389,8 @@
// Statistics
global $wgAbuseFilterProfile;
$stash = ObjectCache::getMainStashInstance();
- $matches_count = $stash->get(
AbuseFilter::filterMatchesKey( $filter ) );
- $total = $stash->get( AbuseFilter::filterUsedKey(
$row->af_group ) );
+ $matches_count = (int)$stash->get(
AbuseFilter::filterMatchesKey( $filter ) );
+ $total = (int)$stash->get( AbuseFilter::filterUsedKey(
$row->af_group ) );
if ( $total > 0 ) {
$matches_percent = sprintf( '%.2f', 100 *
$matches_count / $total );
--
To view, visit https://gerrit.wikimedia.org/r/330074
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8f240dd87664ec99a98b843f9e5c4c8c9eed0532
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/AbuseFilter
Gerrit-Branch: master
Gerrit-Owner: Matěj Suchánek <matejsuchane...@gmail.com>
Gerrit-Reviewer: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: Huji <huji.h...@gmail.com>
Gerrit-Reviewer: Legoktm <lego...@member.fsf.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
