WMDE-leszek has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/330204 )
Change subject: Do not try to change directory when running Phan tests with no
params
......................................................................
Do not try to change directory when running Phan tests with no params
When running tests with:
PHAN=/path/to/phan/phan /path/to/mediawiki-core/tests/phan/bin/phan
the script changes to the home dir (does "cd" with no param),
which results in git error message (unless the home dir happens
to be a git repository).
Change-Id: Ib11e419fb5cca51ceaed0e9c7c86ae9c5c4ae0f2
---
M tests/phan/bin/phan
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/04/330204/1
diff --git a/tests/phan/bin/phan b/tests/phan/bin/phan
index 6ce1e84..61ad7da 100755
--- a/tests/phan/bin/phan
+++ b/tests/phan/bin/phan
@@ -31,7 +31,7 @@
# If the first argument doesn't start with a -, then it's a path
# to another project (extension, skin, etc.) to analyze
-if [[ "$1" != "-"* ]]; then
+if [[ -n "$1" && "$1" != "-"* ]]; then
cd $1
shift
else
--
To view, visit https://gerrit.wikimedia.org/r/330204
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib11e419fb5cca51ceaed0e9c7c86ae9c5c4ae0f2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: WMDE-leszek <leszek.mani...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
