[MediaWiki-commits] [Gerrit] mediawiki...Ids[master]: Introduce CI tests

[Filip (Code Review)]

Filip has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/330239 )

Change subject: Introduce CI tests
......................................................................

Introduce CI tests

Bug: T154453
Change-Id: I38b45fb716fe503fb41447ff57d97147dcdbdec6
---
A composer.json
M ids_body.php
A phpcs.xml
3 files changed, 42 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Ids 
refs/changes/39/330239/1

diff --git a/composer.json b/composer.json
new file mode 100644
index 0000000..98d41d9
--- /dev/null
+++ b/composer.json
@@ -0,0 +1,13 @@
+{
+       "require-dev": {
+               "jakub-onderka/php-parallel-lint": "0.9.2",
+               "mediawiki/mediawiki-codesniffer": "0.7.2"
+       },
+       "scripts": {
+               "fix": "phpcbf",
+               "test": [
+                       "parallel-lint . --exclude vendor",
+                       "phpcs -p -s"
+               ]
+       }
+}
diff --git a/ids_body.php b/ids_body.php
index 76b5268..e6b7603 100644
--- a/ids_body.php
+++ b/ids_body.php
@@ -1,37 +1,39 @@
 <?php
-/*
- * @author Shoichi Chou ( shoichi.c...@gmail.com )
- */
+/**
+* @author Shoichi Chou <shoichi.c...@gmail.com>
+*/
 
-// 0614-2016 change server to https://tools.wmflabs.org/idsgen/
 class IDS {
        static function onParserInit( Parser $parser ) {
                $parser->setHook( 'ids', [ __CLASS__, 'idsRender' ] );
                return true;
        }
-       /*
-        * This method handles IDS tags.
-        *
-        * <ids>⿰電心</ids> ->
-        *      <img align=middle class="ids-char" 
src="https://tools.wmflabs.org/idsgen/⿰電心.svg?字體=宋體"; ...>
-        *
-        * <ids font=楷體粗體>⿰電心</ids> ->
-        *      <img align=middle class="ids-char" 
src="https://tools.wmflabs.org/idsgen/⿰電心.svg?字體=楷體粗體"; ...>
-        *
-        * @see https://www.mediawiki.org/wiki/Manual:Tag_extensions
-        */
+       /**
+       * This method handles IDS tags.
+       *
+       * <ids>⿰電心</ids> ->
+       *       <img align=middle class="ids-char" 
src="https://tools.wmflabs.org/idsgen/⿰電心.svg?字體=宋體"; ...>
+       *
+       * <ids font=楷體粗體>⿰電心</ids> ->
+       *       <img align=middle class="ids-char" 
src="https://tools.wmflabs.org/idsgen/⿰電心.svg?字體=楷體粗體"; ...>
+       *
+       * @see https://www.mediawiki.org/wiki/Manual:Tag_extensions
+       */
        static function idsRender( $input, array $args, Parser $parser, PPFrame 
$frame ) {
                // Support for Simplified "體" (font)
-               $font = isset($args['font']) ? strtr($args['font'] , '体', '體') 
: '宋體';
-               $src = 'https://tools.wmflabs.org/idsgen/' . 
rawurlencode($input) . '.svg?字體=' . rawurlencode($font);
+               $font = isset ( $args['font'] ) ? strtr( $args['font'], '体', 
'體' ) : '宋體';
+               $src = 'https://tools.wmflabs.org/idsgen/' .
+                       rawurlencode( $input ) .
+                       '.svg?字體=' .
+                       rawurlencode( $font );
 
-               return Html::element('img', [
+               return Html::element( 'img', [
                        'align' => 'middle',
                        'class' => 'ids-char',  // helps with custom styling
                        'alt' => $input,
                        'src' => $src,
                        'onerror' => 'this.src = this.src.replace(".svg?字體=", 
".png?字體=")',  // png fallback
                        'style' => 'height: 1em; width: 1em; vertical-align: 
middle; margin: 0.4em 0px 0.7em;'
-               ]);
+               ] );
        }
 }
diff --git a/phpcs.xml b/phpcs.xml
new file mode 100644
index 0000000..d81a292
--- /dev/null
+++ b/phpcs.xml
@@ -0,0 +1,8 @@
+<?xml version="1.0"?>
+<ruleset>
+       <rule ref="vendor/mediawiki/mediawiki-codesniffer/MediaWiki"/>
+       <file>.</file>
+       <arg name="extensions" value="php,php5,inc"/>
+       <arg name="encoding" value="utf8"/>
+       <exclude-pattern>vendor</exclude-pattern>
+</ruleset>

-- 
To view, visit https://gerrit.wikimedia.org/r/330239
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I38b45fb716fe503fb41447ff57d97147dcdbdec6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Ids
Gerrit-Branch: master
Gerrit-Owner: Filip <r...@protonmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits