jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/329478 )
Change subject: Use the monospace hack consistently ...................................................................... Use the monospace hack consistently Change-Id: I6b223e5f0760902c1f34fa5a284703055c763234 --- M modules/ve-mw/ui/styles/pages/ve.ui.MWParameterPage.css M modules/ve-mw/ui/styles/widgets/ve.ui.MWAceEditorWidget.css 2 files changed, 3 insertions(+), 1 deletion(-) Approvals: Bartosz Dziewoński: Looks good to me, approved jenkins-bot: Verified diff --git a/modules/ve-mw/ui/styles/pages/ve.ui.MWParameterPage.css b/modules/ve-mw/ui/styles/pages/ve.ui.MWParameterPage.css index 89c3fc7..f4d955f 100644 --- a/modules/ve-mw/ui/styles/pages/ve.ui.MWParameterPage.css +++ b/modules/ve-mw/ui/styles/pages/ve.ui.MWParameterPage.css @@ -6,6 +6,7 @@ */ .ve-ui-mwParameterPage .ve-ui-mwParameter-wikitextFallbackInput { - font-family: monospace; + /* Specify a valid second value to fix size in Chrome/FF */ + font-family: monospace, 'Courier'; background-color: #ddd; } diff --git a/modules/ve-mw/ui/styles/widgets/ve.ui.MWAceEditorWidget.css b/modules/ve-mw/ui/styles/widgets/ve.ui.MWAceEditorWidget.css index 4f81e64..8ac60b3 100644 --- a/modules/ve-mw/ui/styles/widgets/ve.ui.MWAceEditorWidget.css +++ b/modules/ve-mw/ui/styles/widgets/ve.ui.MWAceEditorWidget.css @@ -8,6 +8,7 @@ .ve-ui-mwAceEditorWidget .ace_editor { border: 1px solid #ccc; margin: 1px; + /* Specify a valid second value to fix size in Chrome/FF */ font-family: monospace, 'Courier'; font-size: inherit; line-height: 1.5; -- To view, visit https://gerrit.wikimedia.org/r/329478 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b223e5f0760902c1f34fa5a284703055c763234 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Esanders <esand...@wikimedia.org> Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com> Gerrit-Reviewer: DLynch <dly...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits