jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/330351 )
Change subject: ClippableElement: Add `min-height` for usability in edge cases
......................................................................
ClippableElement: Add `min-height` for usability in edge cases
Adding `min-height` of 40px to ClippableElement in order to
provide pointer and touch usability.
Bug: T113050
Bug: T146531
Change-Id: Ib7effc496fdfff36cc2808a5d22de132509d8dc5
---
M src/styles/elements/ClippableElement.less
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
Prtksxna: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/src/styles/elements/ClippableElement.less
b/src/styles/elements/ClippableElement.less
index 5b8cd84..3d1485f 100644
--- a/src/styles/elements/ClippableElement.less
+++ b/src/styles/elements/ClippableElement.less
@@ -2,6 +2,7 @@
.oo-ui-clippableElement-clippable {
.oo-ui-box-sizing( border-box );
+ min-height: 3.125em; // equals `40px` at base `font-size: 12.8px`
.theme-oo-ui-clippableElement();
}
--
To view, visit https://gerrit.wikimedia.org/r/330351
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib7effc496fdfff36cc2808a5d22de132509d8dc5
Gerrit-PatchSet: 4
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE <volke...@wikimedia.org>
Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: Gergő Tisza <gti...@wikimedia.org>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: Prtksxna <psax...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
