Mattflaschen has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/330611 )
Change subject: FlowFixInconsistentBoards: Run in update.php, fix updatelog ...................................................................... FlowFixInconsistentBoards: Run in update.php, fix updatelog It was removed from update.php due to slowing down Beta. It's now quick enough that this isn't an issue, and the updatelog issue (causing it to re-run multiple times) if fixed here. Bug: T148057 Change-Id: I39f18db334a8660818211bcc6e8060d6bad85932 (cherry picked from commit e8ef807fb5689e0379368f306988a84a0ad70df0) --- M Hooks.php M maintenance/FlowFixInconsistentBoards.php 2 files changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow refs/changes/11/330611/1 diff --git a/Hooks.php b/Hooks.php index 1bbf2ff..59023cf 100644 --- a/Hooks.php +++ b/Hooks.php @@ -319,6 +319,9 @@ require_once __DIR__.'/maintenance/FlowPopulateRefId.php'; $updater->addPostDatabaseUpdateMaintenance( 'FlowPopulateRefId' ); + require_once __DIR__.'/maintenance/FlowFixInconsistentBoards.php'; + $updater->addPostDatabaseUpdateMaintenance( 'FlowFixInconsistentBoards' ); + /* * Add primary key, but only after we've made sure the newly added * column has been populated (otherwise they'd all be null values) diff --git a/maintenance/FlowFixInconsistentBoards.php b/maintenance/FlowFixInconsistentBoards.php index fe3468c..c4bdd4f 100644 --- a/maintenance/FlowFixInconsistentBoards.php +++ b/maintenance/FlowFixInconsistentBoards.php @@ -164,6 +164,9 @@ break; } } + + // Only mark it as completed if it's run on everything. + return ( !$dryRun && $limit === null && !$this->hasOption( 'namespaceName' ) ); } } -- To view, visit https://gerrit.wikimedia.org/r/330611 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I39f18db334a8660818211bcc6e8060d6bad85932 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Flow Gerrit-Branch: wmf/1.29.0-wmf.6 Gerrit-Owner: Mattflaschen <mflasc...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits