[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Make if predicates more explicit

[Jeroen De Dauw (Code Review)]

Jeroen De Dauw has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/331104 )

Change subject: Make if predicates more explicit
......................................................................

Make if predicates more explicit

Change-Id: I8f0b80475d265e6ad7a3c625c2fa0d2cb569f378
---
M repo/includes/Hooks/InfoActionHookHandler.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/04/331104/1

diff --git a/repo/includes/Hooks/InfoActionHookHandler.php 
b/repo/includes/Hooks/InfoActionHookHandler.php
index f3e5cae..6bec9d1 100644
--- a/repo/includes/Hooks/InfoActionHookHandler.php
+++ b/repo/includes/Hooks/InfoActionHookHandler.php
@@ -125,12 +125,12 @@
         */
        private function formatSubscription( $subscription, Title $title ) {
                $site = $this->siteLookup->getSite( $subscription );
-               if ( !$site ) {
+               if ( $site === null ) {
                        return $subscription;
                }
 
                $url = $site->getPageUrl( 'Special:EntityUsage/' . 
$title->getText() );
-               if ( !$url ) {
+               if ( $url === false ) {
                        return $subscription;
                }
                $element = Html::element( 'a',

-- 
To view, visit https://gerrit.wikimedia.org/r/331104
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8f0b80475d265e6ad7a3c625c2fa0d2cb569f378
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <jeroended...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits