jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/331200 )
Change subject: Avoid IDEA warning about $keys being both a parameter and loop variable ...................................................................... Avoid IDEA warning about $keys being both a parameter and loop variable Change-Id: Id562053a71f135fa863cb88b5f081982c01575cf --- M includes/libs/objectcache/WANObjectCache.php 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Legoktm: Looks good to me, approved jenkins-bot: Verified Jeroen De Dauw: Looks good to me, but someone else must approve diff --git a/includes/libs/objectcache/WANObjectCache.php b/includes/libs/objectcache/WANObjectCache.php index 8d3c6d9..01a9149 100644 --- a/includes/libs/objectcache/WANObjectCache.php +++ b/includes/libs/objectcache/WANObjectCache.php @@ -275,8 +275,8 @@ $checkKeysForAll = []; $checkKeysByKey = []; $checkKeysFlat = []; - foreach ( $checkKeys as $i => $keys ) { - $prefixed = self::prefixCacheKeys( (array)$keys, self::TIME_KEY_PREFIX ); + foreach ( $checkKeys as $i => $checkKeyGroup ) { + $prefixed = self::prefixCacheKeys( (array)$checkKeyGroup, self::TIME_KEY_PREFIX ); $checkKeysFlat = array_merge( $checkKeysFlat, $prefixed ); // Is this check keys for a specific cache key, or for all keys being fetched? if ( is_int( $i ) ) { -- To view, visit https://gerrit.wikimedia.org/r/331200 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id562053a71f135fa863cb88b5f081982c01575cf Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Aaron Schulz <asch...@wikimedia.org> Gerrit-Reviewer: Jeroen De Dauw <jeroended...@gmail.com> Gerrit-Reviewer: Legoktm <lego...@member.fsf.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits