jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/329774 )
Change subject: Remove warning about missing site ID
......................................................................
Remove warning about missing site ID
Seems to interfere with qunit somehow.
Bug: T153729
Bug: T153597
Change-Id: I1a52ce07943f20ccd63f5d357c5e006cd721da64
(cherry picked from commit 64a6e066509c3aa86ff71dafad17630079726253)
(cherry picked from commit 63a469131a2c4ca70898ce144994d208b274058b)
---
M extensions/Wikibase/client/includes/WikibaseClient.php
1 file changed, 0 insertions(+), 2 deletions(-)
Approvals:
Reedy: Looks good to me, approved
jenkins-bot: Verified
Objections:
Addshore: There's a problem with this change, please improve
diff --git a/extensions/Wikibase/client/includes/WikibaseClient.php
b/extensions/Wikibase/client/includes/WikibaseClient.php
index cd95980..795673b 100644
--- a/extensions/Wikibase/client/includes/WikibaseClient.php
+++ b/extensions/Wikibase/client/includes/WikibaseClient.php
@@ -712,8 +712,6 @@
$site = $this->getSiteStore()->getSite( $siteId );
if ( !$site ) {
- wfWarn( 'Cannot find site ' . $siteId . ' in
sites table' );
-
return true;
}
--
To view, visit https://gerrit.wikimedia.org/r/329774
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1a52ce07943f20ccd63f5d357c5e006cd721da64
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikidata
Gerrit-Branch: REL1_28
Gerrit-Owner: Paladox <thomasmulhall...@yahoo.com>
Gerrit-Reviewer: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: Daniel Kinzler <daniel.kinz...@wikimedia.de>
Gerrit-Reviewer: Gergő Tisza <gti...@wikimedia.org>
Gerrit-Reviewer: Legoktm <lego...@member.fsf.org>
Gerrit-Reviewer: Paladox <thomasmulhall...@yahoo.com>
Gerrit-Reviewer: Reedy <re...@wikimedia.org>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
