Sebschlicht2 has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/331633 )
Change subject: comment on sorting -- introduce change-ids for git-review with
this commit
......................................................................
comment on sorting -- introduce change-ids for git-review with this commit
Change-Id: Ibdf7d38b8e8ee60e38dcf3712316b2ebbf5615c4
---
M includes/structure/MoocContentStructureProvider.php
1 file changed, 1 insertion(+), 0 deletions(-)
diff --git a/includes/structure/MoocContentStructureProvider.php
b/includes/structure/MoocContentStructureProvider.php
index 1e61e38..c5180b7 100644
--- a/includes/structure/MoocContentStructureProvider.php
+++ b/includes/structure/MoocContentStructureProvider.php
@@ -57,6 +57,7 @@
// load structure from item titles
+ //TODO this requires the items to be sorted by title while children
arrays MUST maintain the original creation ordering
$rootItem = array_shift( $items );
$prevLesson = null;
foreach ( $items as $item ) {
--
To view, visit https://gerrit.wikimedia.org/r/331633
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibdf7d38b8e8ee60e38dcf3712316b2ebbf5615c4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MOOC
Gerrit-Branch: master
Gerrit-Owner: Sebschlicht2 <sebschli...@uni-koblenz.de>
Gerrit-Reviewer: Sebschlicht2 <sebschli...@uni-koblenz.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
