MtDu has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/332085 )
Change subject: Remove wfIncrStats logging from Special:MobileOptions
......................................................................
Remove wfIncrStats logging from Special:MobileOptions
Currently, we log mobile preference updates using wfIncrStats.
However, this is made redundant because of T122504.
As a result, this patch removes these unnecessary calls.
Bug: T132134
Change-Id: I14d05a7ec78f88fdc21d3550300b01a1329c4078
---
M includes/specials/SpecialMobileOptions.php
1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/85/332085/1
diff --git a/includes/specials/SpecialMobileOptions.php
b/includes/specials/SpecialMobileOptions.php
index 7d91ecb..d3a62de 100644
--- a/includes/specials/SpecialMobileOptions.php
+++ b/includes/specials/SpecialMobileOptions.php
@@ -38,7 +38,6 @@
parent::execute( $par );
$context = MobileContext::singleton();
- wfIncrStats( 'mobile.options.views' );
$this->returnToTitle = Title::newFromText(
$this->getRequest()->getText( 'returnto' ) );
if ( !$this->returnToTitle ) {
$this->returnToTitle = Title::newMainPage();
@@ -243,7 +242,6 @@
if ( $user->isLoggedIn() && !$user->matchEditToken(
$request->getVal( 'token' ) ) ) {
$errorText = __METHOD__ . '(): token mismatch';
- wfIncrStats( 'mobile.options.errors' );
wfDebugLog( 'mobile', $errorText );
$this->getOutput()->addHTML( '<div class="error">'
. $this->msg( "mobile-frontend-save-error"
)->parse()
@@ -255,7 +253,6 @@
$this->addSettingsForm();
return;
}
- wfIncrStats( 'mobile.options.saves' );
if ( $request->getBool( 'enableBeta' ) ) {
$group = 'beta';
--
To view, visit https://gerrit.wikimedia.org/r/332085
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I14d05a7ec78f88fdc21d3550300b01a1329c4078
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: MtDu <justin.d...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
