Juniorsys has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/332094 )
Change subject: bacula module: Trailing commas, full class names
......................................................................
bacula module: Trailing commas, full class names
Add trailing commas to abide by the Coding Style guidelines
Use class full names for includes, as relative names are not allowed in
future Puppet versions
Bug: T93645
Change-Id: Ib0512e582619062418d2e8a609c7c23cdc71baf2
---
M modules/bacula/manifests/client.pp
M modules/bacula/tests/client.pp
M modules/bacula/tests/console.pp
M modules/bacula/tests/director.pp
M modules/bacula/tests/storage.pp
5 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/94/332094/1
diff --git a/modules/bacula/manifests/client.pp
b/modules/bacula/manifests/client.pp
index a069b3f..467482a 100644
--- a/modules/bacula/manifests/client.pp
+++ b/modules/bacula/manifests/client.pp
@@ -54,7 +54,7 @@
require => [
Package['bacula-fd'],
Exec['concat-bacula-keypair'],
- ]
+ ],
}
# To avoid reimplementing a PKI infrastructure we use puppet's already well
diff --git a/modules/bacula/tests/client.pp b/modules/bacula/tests/client.pp
index c984cd0..35711d7 100644
--- a/modules/bacula/tests/client.pp
+++ b/modules/bacula/tests/client.pp
@@ -1,6 +1,6 @@
#
-class { 'bacula::client':
+class { '::bacula::client':
director => 'dir.example.com',
catalog => 'example',
file_retention => '60 days',
diff --git a/modules/bacula/tests/console.pp b/modules/bacula/tests/console.pp
index ee48fc1..661a846 100644
--- a/modules/bacula/tests/console.pp
+++ b/modules/bacula/tests/console.pp
@@ -1,5 +1,5 @@
#
-class { 'bacula::console':
+class { '::bacula::console':
director => 'dir.example.com',
}
diff --git a/modules/bacula/tests/director.pp b/modules/bacula/tests/director.pp
index e5b2ea9..8029c97 100644
--- a/modules/bacula/tests/director.pp
+++ b/modules/bacula/tests/director.pp
@@ -1,6 +1,6 @@
#
-class { 'bacula::director':
+class { '::bacula::director':
sqlvariant => 'mysql',
max_dir_concur_jobs => '10',
}
diff --git a/modules/bacula/tests/storage.pp b/modules/bacula/tests/storage.pp
index 1d087b1..66f042a 100644
--- a/modules/bacula/tests/storage.pp
+++ b/modules/bacula/tests/storage.pp
@@ -1,6 +1,6 @@
#
-class { 'bacula::storage':
+class { '::bacula::storage':
director => 'dir.example.com',
sd_max_concur_jobs => 5,
sqlvariant => 'mysql',
--
To view, visit https://gerrit.wikimedia.org/r/332094
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib0512e582619062418d2e8a609c7c23cdc71baf2
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Juniorsys <juniorsys_wikime...@outlook.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
