jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/332349 )
Change subject: Follow-up 1dc6a45: Emit deprecations from
Element#scrollIntoView callback
......................................................................
Follow-up 1dc6a45: Emit deprecations from Element#scrollIntoView callback
Change-Id: I21ce2c187064dac8a27548d2b4087d1c49e47834
---
M src/Element.js
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/Element.js b/src/Element.js
index 63401e2..b47f5c4 100644
--- a/src/Element.js
+++ b/src/Element.js
@@ -607,6 +607,9 @@
animations = {};
callback = typeof config.complete === 'function' && config.complete;
+ if ( callback ) {
+ OO.ui.warnDeprecation( 'Element#scrollIntoView: The `complete`
callback config option is deprecated. Use the return promise instead.' );
+ }
container = this.getClosestScrollableContainer( el, config.direction );
$container = $( container );
elementDimensions = this.getDimensions( el );
--
To view, visit https://gerrit.wikimedia.org/r/332349
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I21ce2c187064dac8a27548d2b4087d1c49e47834
Gerrit-PatchSet: 2
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
