jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/332118 )
Change subject: PanelLayout: Remove 3D appearance of framed panels and harmonise padding ...................................................................... PanelLayout: Remove 3D appearance of framed panels and harmonise padding Removing the spatial accentuated appearance for framed panels, and harmonise the padding on PanelLayout. Bug: T155335 Change-Id: Ia21bd3b94e5a7453c6216af35941cf3c6b4751fe --- M src/themes/apex/layouts.less M src/themes/mediawiki/layouts.less 2 files changed, 7 insertions(+), 2 deletions(-) Approvals: Prtksxna: Looks good to me, but someone else must approve jenkins-bot: Verified TheDJ: Looks good to me, but someone else must approve Jforrester: Looks good to me, approved diff --git a/src/themes/apex/layouts.less b/src/themes/apex/layouts.less index adaf8c3..eed784f 100644 --- a/src/themes/apex/layouts.less +++ b/src/themes/apex/layouts.less @@ -148,7 +148,6 @@ &-framed { border-radius: 0.5em; - box-shadow: 0 0.25em 1em rgba( 0, 0, 0, 0.25 ); } &-padded&-framed { diff --git a/src/themes/mediawiki/layouts.less b/src/themes/mediawiki/layouts.less index 8e6b0e8..3381390 100644 --- a/src/themes/mediawiki/layouts.less +++ b/src/themes/mediawiki/layouts.less @@ -154,12 +154,18 @@ .theme-oo-ui-panelLayout () { &-padded { padding: 1.25em; + + &.oo-ui-formLayout > .oo-ui-fieldsetLayout { + .oo-ui-labelElement-label, + .oo-ui-iconElement-icon { + margin-top: -0.25em; // Reduce distance for `line-height` and only if element visible + } + } } &-framed { border: @border-dialog; border-radius: @border-radius-default; - box-shadow: @box-shadow-dialog; } &-padded&-framed { -- To view, visit https://gerrit.wikimedia.org/r/332118 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia21bd3b94e5a7453c6216af35941cf3c6b4751fe Gerrit-PatchSet: 2 Gerrit-Project: oojs/ui Gerrit-Branch: master Gerrit-Owner: VolkerE <volke...@wikimedia.org> Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org> Gerrit-Reviewer: Prtksxna <psax...@wikimedia.org> Gerrit-Reviewer: TheDJ <hartman.w...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits