jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/332640 )
Change subject: Add test case for Opus file check
......................................................................
Add test case for Opus file check
Test case for Opus file check so we don't regress!
Confirms the fix for T151352 that Opus files return
type 'audio' and not 'multimedia'.
Bug: T151352
Change-Id: Ib868793d90b60609ccec25726e6fbaa28bffebaf
---
A tests/phpunit/data/media/say-test.opus
M tests/phpunit/includes/libs/mime/MimeAnalyzerTest.php
2 files changed, 10 insertions(+), 0 deletions(-)
Approvals:
EBernhardson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/phpunit/data/media/say-test.opus
b/tests/phpunit/data/media/say-test.opus
new file mode 100644
index 0000000..168d218
--- /dev/null
+++ b/tests/phpunit/data/media/say-test.opus
Binary files differ
diff --git a/tests/phpunit/includes/libs/mime/MimeAnalyzerTest.php
b/tests/phpunit/includes/libs/mime/MimeAnalyzerTest.php
index 85927a3..53a36c5 100644
--- a/tests/phpunit/includes/libs/mime/MimeAnalyzerTest.php
+++ b/tests/phpunit/includes/libs/mime/MimeAnalyzerTest.php
@@ -59,4 +59,14 @@
$actualType = $this->mimeAnalyzer->getMediaType( $oggFile,
'application/ogg' );
$this->assertEquals( $actualType, MEDIATYPE_AUDIO );
}
+
+ /**
+ * Test to make sure that Opus audio files don't trigger
+ * MEDIATYPE_MULTIMEDIA (bug T151352)
+ */
+ function testOpusRecognize() {
+ $oggFile = __DIR__ . '/../../../data/media/say-test.opus';
+ $actualType = $this->mimeAnalyzer->getMediaType( $oggFile,
'application/ogg' );
+ $this->assertEquals( $actualType, MEDIATYPE_AUDIO );
+ }
}
--
To view, visit https://gerrit.wikimedia.org/r/332640
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib868793d90b60609ccec25726e6fbaa28bffebaf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Brion VIBBER <br...@wikimedia.org>
Gerrit-Reviewer: EBernhardson <ebernhard...@wikimedia.org>
Gerrit-Reviewer: TheDJ <hartman.w...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
