Harej has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/332706 )
Change subject: Forces column number in member lists to be 0 for JS editor
purposes
......................................................................
Forces column number in member lists to be 0 for JS editor purposes
Member lists are rendered as two-column but are actually one column in the
underlying JSON. This causes cognitive dissonance. Resolving by pretending
there is only one column.
Bug: T155485
Change-Id: I25c7ac9e61bbf2e3451e6d9d1d20ef6b6d384803
---
M modules/ext.CollaborationKit.list.edit.js
1 file changed, 5 insertions(+), 0 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CollaborationKit
refs/changes/06/332706/1
diff --git a/modules/ext.CollaborationKit.list.edit.js
b/modules/ext.CollaborationKit.list.edit.js
index 613e90c..2fda755 100644
--- a/modules/ext.CollaborationKit.list.edit.js
+++ b/modules/ext.CollaborationKit.list.edit.js
@@ -54,6 +54,11 @@
modifyExistingItem = function ( itemName, colId ) {
getCurrentJson( mw.config.get( 'wgArticleId' ), function ( res
) {
var done = false;
+ // Member lists pretend to have two columns (active and
inactive),
+ // but in the source code, it's only one column. This
forces that.
+ if ( mw.config.get( 'wgCollaborationKitIsMemberList' )
) {
+ colId = 0;
+ }
$.each( res.content.columns[ colId ].items, function (
index ) {
if ( this.title === itemName ) {
done = true;
--
To view, visit https://gerrit.wikimedia.org/r/332706
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I25c7ac9e61bbf2e3451e6d9d1d20ef6b6d384803
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CollaborationKit
Gerrit-Branch: master
Gerrit-Owner: Harej <jamesmh...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
