jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/331936 )
Change subject: Remove deprecated `.mw-ui-constructive` class for text and
anchors
......................................................................
Remove deprecated `.mw-ui-constructive` class for text and anchors
Removing deprecated, no longer in use `.mw-ui-constructive` modifier
CSS class for mediawiki.UI text and anchors.
Bug: T155203
Change-Id: I9bcd90ebbebbaece13e0cf9f36afd5964d49dc3b
---
M resources/src/mediawiki.ui/components/anchors.less
M resources/src/mediawiki.ui/components/text.less
2 files changed, 3 insertions(+), 11 deletions(-)
Approvals:
jenkins-bot: Verified
Jdlrobson: Looks good to me, approved
diff --git a/resources/src/mediawiki.ui/components/anchors.less
b/resources/src/mediawiki.ui/components/anchors.less
index 4c4e129..ff38d0d 100644
--- a/resources/src/mediawiki.ui/components/anchors.less
+++ b/resources/src/mediawiki.ui/components/anchors.less
@@ -48,22 +48,16 @@
&.mw-ui-destructive {
.mixin-mw-ui-anchor-styles( @colorDestructive );
}
-
- //`.mw-ui-constructive` is deprecated; consolidated with `progressive`,
see T110555
- &.mw-ui-constructive {
- .mixin-mw-ui-anchor-styles( @colorConstructive );
- }
}
/*
Quiet anchors
-Use quiet anchors when they are less important and alongside other
progressive/destructive/progressive
+Use quiet anchors when they are less important and alongside other
progressive/destructive
anchors. Use of quiet anchors is not recommended on mobile/tablet due to lack
of hover state.
Markup:
<a href="#" class="mw-ui-anchor mw-ui-progressive mw-ui-quiet">Progressive</a>
-<a href="#" class="mw-ui-anchor mw-ui-constructive
mw-ui-quiet">Constructive</a>
<a href="#" class="mw-ui-anchor mw-ui-destructive mw-ui-quiet">Destructive</a>
Styleguide 6.2.1.
diff --git a/resources/src/mediawiki.ui/components/text.less
b/resources/src/mediawiki.ui/components/text.less
index 5551745..30593bf 100644
--- a/resources/src/mediawiki.ui/components/text.less
+++ b/resources/src/mediawiki.ui/components/text.less
@@ -16,7 +16,6 @@
Context classes may be used on elements with only plain-text content with the
mw-ui-text base. When the context classes
are used on interactive and block-level elements, the appropriate alternative
base type classes should also be used. For
example, mw-ui-anchor with A, or mw-ui-button with buttons.
-'Constructive' is deprecated and merged with 'Progressive'.
Markup:
<span class="mw-ui-text mw-ui-progressive">Progressive</span>
@@ -28,11 +27,10 @@
.mw-ui-text {
// The selector order is like this on purpose; IE 6 ignores the second
selector,
// so we don't want to accidentally apply this color on all
mw-ui-CONTEXT classes
- .mw-ui-progressive&,
- .mw-ui-constructive& {
+ &.mw-ui-progressive {
color: @colorProgressive;
}
- .mw-ui-destructive& {
+ &.mw-ui-destructive {
color: @colorDestructive;
}
}
\ No newline at end of file
--
To view, visit https://gerrit.wikimedia.org/r/331936
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9bcd90ebbebbaece13e0cf9f36afd5964d49dc3b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: VolkerE <volke...@wikimedia.org>
Gerrit-Reviewer: Jack Phoenix <j...@countervandalism.net>
Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
