Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/332892 )
Change subject: WIP: Limit the width of search in tablet mode
......................................................................
WIP: Limit the width of search in tablet mode
Problems:
* In tablet focusing input causes search to jump slightly to right
* Re-evaluate the (min-width: 62.5em) threshold with Nirzar
(below this, but above 720px rendering issues)
Change-Id: I1aaae597c5805126ed893f4de71263f6da073b8b
---
M minerva.less/minerva.variables.less
M resources/mobile.search/SearchOverlay.less
M resources/skins.minerva.base.styles/ui.less
3 files changed, 22 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/92/332892/1
diff --git a/minerva.less/minerva.variables.less
b/minerva.less/minerva.variables.less
index 9d20b40..081fe49 100644
--- a/minerva.less/minerva.variables.less
+++ b/minerva.less/minerva.variables.less
@@ -7,6 +7,9 @@
@rightDrawerWidth: 60%;
@primaryNavBackgroundColor: @colorGray14;
+// Header
+@searchBarWidth: 375px;
+
// Headings
@firstHeadingFontSize: 2.6525em; // 42px
@pageActionFontSize: 1.1em; // Icons are 24px square.
diff --git a/resources/mobile.search/SearchOverlay.less
b/resources/mobile.search/SearchOverlay.less
index 575c78c..47fd3f3 100644
--- a/resources/mobile.search/SearchOverlay.less
+++ b/resources/mobile.search/SearchOverlay.less
@@ -197,3 +197,21 @@
}
}
}
+
+@media all and ( min-width: @deviceWidthTablet ) {
+ .search-overlay {
+ .overlay-content,
+ .overlay-header {
+ width: @searchBarWidth;
+ }
+
+ .cancel {
+ position: absolute;
+ top: 15px;
+ }
+
+ .overlay-title {
+ padding-left: 0;
+ }
+ }
+}
diff --git a/resources/skins.minerva.base.styles/ui.less
b/resources/skins.minerva.base.styles/ui.less
index eef9ac1..a575775 100644
--- a/resources/skins.minerva.base.styles/ui.less
+++ b/resources/skins.minerva.base.styles/ui.less
@@ -41,7 +41,7 @@
width: 0;
.search {
- width: 375px;
+ width: @searchBarWidth;
margin-left: 95px;
}
}
--
To view, visit https://gerrit.wikimedia.org/r/332892
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1aaae597c5805126ed893f4de71263f6da073b8b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
