jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/332897 )
Change subject: Revert "Use the parser to get each template parameter in the Index: namespace" ...................................................................... Revert "Use the parser to get each template parameter in the Index: namespace" This reverts commit cb081bc3c8c31152a87a4e590662b12522ca0204. Bug: T155682 Change-Id: I662b45fe3eea8cad022098582116465676d20c19 --- M includes/index/ProofreadIndexPage.php 1 file changed, 3 insertions(+), 16 deletions(-) Approvals: Chad: Looks good to me, approved jenkins-bot: Verified diff --git a/includes/index/ProofreadIndexPage.php b/includes/index/ProofreadIndexPage.php index 0554b4b..e1543f6 100644 --- a/includes/index/ProofreadIndexPage.php +++ b/includes/index/ProofreadIndexPage.php @@ -235,27 +235,14 @@ * @return array of ProofreadIndexEntry */ public function getIndexEntries() { - global $wgUser, $wgContLang; if ( $this->entries === null ) { $text = $this->getText(); $values = []; - - $parser = self::getParser(); - $options = new ParserOptions( $wgUser, $wgContLang ); - $parser->startExternalParse( $this->title, $options, Parser::OT_PLAIN, true ); - - $dom = $parser->preprocessToDom( $text ); - $frame = $parser->getPreprocessor()->newFrame(); - $dom = $dom->getFirstChild(); - $childframe = $frame->newChild( $dom->getChildrenOfType( 'part' ) ); - foreach ( $this->config as $varName => $property ) { - if ( !array_key_exists( $varName, $childframe->namedArgs ) ) { - continue; + $tagPattern = "/\n\|" . preg_quote( $varName, '/' ) . "=(.*?)\n(\||\}\})/is"; + if ( preg_match( $tagPattern, $text, $matches ) ) { + $values[$varName] = $matches[1]; } - $values[$varName] = $parser->mStripState->unstripBoth( $parser->getPreprocessor()->newFrame()->expand( - $childframe->namedArgs[$varName], PPFrame::RECOVER_ORIG - ) ); } $this->entries = $this->getIndexEntriesFromIndexContent( $values ); } -- To view, visit https://gerrit.wikimedia.org/r/332897 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I662b45fe3eea8cad022098582116465676d20c19 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/ProofreadPage Gerrit-Branch: wmf/1.29.0-wmf.8 Gerrit-Owner: Chad <ch...@wikimedia.org> Gerrit-Reviewer: Chad <ch...@wikimedia.org> Gerrit-Reviewer: Legoktm <lego...@member.fsf.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits