jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/331787 )
Change subject: ve.ui.MWMapsDialog: Set $overlay for PopupButtonWidget
......................................................................
ve.ui.MWMapsDialog: Set $overlay for PopupButtonWidget
So that its dimensions are not limited by the dialog's dimensions.
Depends on Ibab4be23b20edef23686e4563db2acc0d69f52b6 in OOjs UI.
Change-Id: I72a9555c4b5da49414ea35ad98d37192f77c7ddc
---
M modules/ve-maps/ve.ui.MWMapsDialog.js
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Esanders: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-maps/ve.ui.MWMapsDialog.js
b/modules/ve-maps/ve.ui.MWMapsDialog.js
index c85a586..e90811a 100644
--- a/modules/ve-maps/ve.ui.MWMapsDialog.js
+++ b/modules/ve-maps/ve.ui.MWMapsDialog.js
@@ -100,6 +100,7 @@
.append( $( '<tr>' ).append( '<th>' + ve.msg(
'visualeditor-mwmapsdialog-position-zoom' ) + '</th>' ).append(
this.$currentPositionZoomField ) );
positionPopupButton = new OO.ui.PopupButtonWidget( {
+ $overlay: this.$overlay,
label: ve.msg( 'visualeditor-mwmapsdialog-position-button' ),
icon: 'info',
framed: false,
--
To view, visit https://gerrit.wikimedia.org/r/331787
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I72a9555c4b5da49414ea35ad98d37192f77c7ddc
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Kartographer
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: MaxSem <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
