Henning Snater has submitted this change and it was merged.
Change subject: string valueview is able to handle null as value now
......................................................................
string valueview is able to handle null as value now
Change-Id: Ibee31f8a2e20c0adcb93acfcb90adaeaa296529f
---
M DataTypes/resources/jquery.valueview.SingleInputWidget.js
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Henning Snater: Verified; Looks good to me, approved
jenkins-bot: Checked
diff --git a/DataTypes/resources/jquery.valueview.SingleInputWidget.js
b/DataTypes/resources/jquery.valueview.SingleInputWidget.js
index 837383c..7ee487d 100644
--- a/DataTypes/resources/jquery.valueview.SingleInputWidget.js
+++ b/DataTypes/resources/jquery.valueview.SingleInputWidget.js
@@ -96,7 +96,8 @@
* @see jQuery.valueview.Widget._displayValue
*/
_displayValue: function( value ) {
- this.$input.val( value.getValue() );
+ var textValue = value === null ? '' : value.getValue();
+ this.$input.val( textValue );
},
/**
--
To view, visit https://gerrit.wikimedia.org/r/49992
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibee31f8a2e20c0adcb93acfcb90adaeaa296529f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DataValues
Gerrit-Branch: master
Gerrit-Owner: Daniel Werner <daniel.wer...@wikimedia.de>
Gerrit-Reviewer: Henning Snater <henning.sna...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
