jenkins-bot has submitted this change and it was merged. Change subject: Use defineTour and the new isSinglePage field. ......................................................................
Use defineTour and the new isSinglePage field. Change-Id: Idce6793d2c93e0d3df9639e581d4cfb61c47bc72 --- M resources/tours/gettingstartedpage.js 1 file changed, 25 insertions(+), 32 deletions(-) Approvals: Ori.livneh: Looks good to me, approved jenkins-bot: Verified diff --git a/resources/tours/gettingstartedpage.js b/resources/tours/gettingstartedpage.js index 9a85ce9..2ca4596 100644 --- a/resources/tours/gettingstartedpage.js +++ b/resources/tours/gettingstartedpage.js @@ -1,34 +1,27 @@ -// This code runs on the GettingStarted page itself. It uses GuidedTour for tooltips, -// rather than a full tour. The tour is not self-launching. -( function ( window, document, $, mw, guiders ) { - var gt = mw.guidedTour; +// This code runs on the GettingStarted page itself. It uses GuidedTour for a single-page tour, +// rather than a full tour. The tour is not launched automatically, and does not move between steps +// automatically. +( function ( window, document, $, mw, gt ) { + gt.defineTour( { + name: 'gettingstartedpage', - gt.currentTour = 'gettingstartedpage'; + steps: [ { + titlemsg: 'guidedtour-tour-gettingstartedpage-copy-editing-title', + descriptionmsg: 'guidedtour-tour-gettingstartedpage-copy-editing-description', + attachTo: '.onboarding-help.copyedit', + position: 'right' + }, { + titlemsg: 'guidedtour-tour-gettingstartedpage-fix-spelling-title', + descriptionmsg: 'guidedtour-tour-gettingstartedpage-fix-spelling-description', + attachTo: '.onboarding-help.fixspelling', + position: 'right' + }, { + titlemsg: 'guidedtour-tour-gettingstartedpage-add-links-title', + descriptionmsg: 'guidedtour-tour-gettingstartedpage-add-links-description', + attachTo: '.onboarding-help.addlinks', + position: 'right' + } ], - gt.initGuider({ - id: 'gt-gettingstartedpage-1', - titlemsg: 'guidedtour-tour-gettingstartedpage-copy-editing-title', - descriptionmsg: 'guidedtour-tour-gettingstartedpage-copy-editing-description', - attachTo: '.onboarding-help.copyedit', - position: '3', - showEndTour: false - }); - - gt.initGuider({ - id: 'gt-gettingstartedpage-2', - titlemsg: 'guidedtour-tour-gettingstartedpage-fix-spelling-title', - descriptionmsg: 'guidedtour-tour-gettingstartedpage-fix-spelling-description', - attachTo: '.onboarding-help.fixspelling', - position: '3', - showEndTour: false - }); - - gt.initGuider({ - id: 'gt-gettingstartedpage-3', - titlemsg: 'guidedtour-tour-gettingstartedpage-add-links-title', - descriptionmsg: 'guidedtour-tour-gettingstartedpage-add-links-description', - attachTo: '.onboarding-help.addlinks', - position: '3', - showEndTour: false - }); -} ( window, document, jQuery, mediaWiki, mediaWiki.libs.guiders ) ); + isSinglePage: true + } ); +} (window, document, jQuery, mediaWiki, mediaWiki.guidedTour ) ); -- To view, visit https://gerrit.wikimedia.org/r/48780 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idce6793d2c93e0d3df9639e581d4cfb61c47bc72 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/GettingStarted Gerrit-Branch: feature/gettingstartedv2 Gerrit-Owner: Mattflaschen <mflasc...@wikimedia.org> Gerrit-Reviewer: Mattflaschen <mflasc...@wikimedia.org> Gerrit-Reviewer: Ori.livneh <o...@wikimedia.org> Gerrit-Reviewer: Spage <sp...@wikimedia.org> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits