Dalba has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/333216 )
Change subject: pagegenerators_tests.py: Test that getCategory returns the
correct site
......................................................................
pagegenerators_tests.py: Test that getCategory returns the correct site
0c33e28954b341ac32065198e5103d2ffa9b3eda fixed a bug that was causing
getCategory return a category from the wrong site (the default site instead
of the user-specified site). This patch adds a test for it.
Bug: T155687
Change-Id: I062a8af1c912ad6830cab81305d89cd34b873250
---
M tests/pagegenerators_tests.py
1 file changed, 14 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core
refs/changes/16/333216/1
diff --git a/tests/pagegenerators_tests.py b/tests/pagegenerators_tests.py
index 77eba56..29317a1 100755
--- a/tests/pagegenerators_tests.py
+++ b/tests/pagegenerators_tests.py
@@ -7,8 +7,6 @@
# Distributed under the terms of the MIT license.
from __future__ import absolute_import, unicode_literals
-__version__ = '$Id$'
-
import calendar
import datetime
import json
@@ -38,6 +36,9 @@
RecentChangesTestCase,
)
from tests.thread_tests import GeneratorIntersectTestCase
+
+
+__version__ = '$Id$'
en_wp_page_titles = (
# just a bunch of randomly selected titles for English Wikipedia tests
@@ -1110,6 +1111,17 @@
page2 = next(gen)
self.assertEqual(page2.title(), 'Q286874')
+ def test_get_category_of_different_site(self):
+ """Test the getCategory method."""
+ gf = pagegenerators.GeneratorFactory(site=self.site)
+ cat, startfrom = gf.getCategory('foo')
+ self.assertEqual(cat.site.code, 'wikidata')
+ gf = pagegenerators.GeneratorFactory(
+ pywikibot.Site('en', 'wikipedia')
+ )
+ cat, startfrom = gf.getCategory('foo')
+ self.assertEqual(cat.site.code, 'en')
+
class TestLogeventsFactoryGenerator(DefaultSiteTestCase,
DeprecationTestCase):
--
To view, visit https://gerrit.wikimedia.org/r/333216
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I062a8af1c912ad6830cab81305d89cd34b873250
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Dalba <dalba.w...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
