Daniel Werner has uploaded a new change for review.
https://gerrit.wikimedia.org/r/50006
Change subject: fix of dv.util.inherit test which was using global assert
......................................................................
fix of dv.util.inherit test which was using global assert
global assert seems to be removed in core now, so this started failing.
Change-Id: I41f0f068da4c73d7d5976d3ac0c041c7fc98e7a6
---
M DataValues/resources/dataValues.util.js
M DataValues/tests/qunit/dataValues.util.inherit.tests.js
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DataValues
refs/changes/06/50006/1
diff --git a/DataValues/resources/dataValues.util.js
b/DataValues/resources/dataValues.util.js
index e5c1d2a..8788167 100644
--- a/DataValues/resources/dataValues.util.js
+++ b/DataValues/resources/dataValues.util.js
@@ -4,7 +4,7 @@
* @licence GNU GPL v2+
* @author Daniel Werner
*/
-( function( $, dv, undefined ) {
+( function( $, dv ) {
'use strict';
/**
diff --git a/DataValues/tests/qunit/dataValues.util.inherit.tests.js
b/DataValues/tests/qunit/dataValues.util.inherit.tests.js
index 3c06751..d09b35f 100644
--- a/DataValues/tests/qunit/dataValues.util.inherit.tests.js
+++ b/DataValues/tests/qunit/dataValues.util.inherit.tests.js
@@ -74,7 +74,7 @@
delete( proto.constructor ); // constructor is an extra
thing, set by inherit()
}
if( members !== null ) {
- assert.deepEqual(
+ QUnit.assert.deepEqual(
proto,
( members !== null ? members : {} ),
'Prototype of returned constructor has all
extension properties set'
--
To view, visit https://gerrit.wikimedia.org/r/50006
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I41f0f068da4c73d7d5976d3ac0c041c7fc98e7a6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DataValues
Gerrit-Branch: master
Gerrit-Owner: Daniel Werner <daniel.wer...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
