jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/333040 )
Change subject: composer: Add phpcs and make pass (auto-fixed) ...................................................................... composer: Add phpcs and make pass (auto-fixed) Ignored rules for now: * Generic.Files.LineLength.TooLong * Generic.CodeAnalysis.ForLoopWithTestFunctionCall.NotAllowed * Generic.CodeAnalysis.UnconditionalIfStatement.Found * MediaWiki.NamingConventions.ValidGlobalName.wgPrefix (!) * MediaWiki.ControlStructures.AssignmentInControlStructures.AssignmentInControlStructures Change-Id: I30374110e579fdb946797028cfd756a0f95add6b --- M .gitignore M EducationProgram.hooks.php M EducationProgram.i18n.ns.php M EducationProgram.i18n.php M EducationProgram.php M EducationProgram.settings.php M composer.json M includes/ArticleAdder.php M includes/ArticleStore.php M includes/CourseActivityView.php M includes/CourseUndeletionHelper.php M includes/DYKBox.php M includes/DiffTable.php M includes/ErrorPageErrorWithSelflink.php M includes/Events/EditEventCreator.php M includes/Events/EventGroup.php M includes/Events/EventQuery.php M includes/Events/EventStore.php M includes/Events/RecentPageEventGrouper.php M includes/Events/Timeline.php M includes/Events/TimelineGroup.php M includes/FailForm.php M includes/HTMLDateField.php M includes/IRole.php M includes/LogFormatter.php M includes/Menu.php M includes/OrgDeletionHelper.php M includes/RevisionAction.php M includes/RevisionDiff.php M includes/RoleObject.php M includes/Store/CourseStore.php M includes/UPCUserCourseFinder.php M includes/UserCourseFinder.php M includes/UserMergeArticleReviewersJob.php M includes/UserRolesMessage.php M includes/Utils.php M includes/actions/Action.php M includes/actions/AddArticleAction.php M includes/actions/AddReviewerAction.php M includes/actions/CompareAction.php M includes/actions/DeleteAction.php M includes/actions/EditAction.php M includes/actions/EditCourseAction.php M includes/actions/EditOrgAction.php M includes/actions/HistoryAction.php M includes/actions/RemoveReviewerAction.php M includes/actions/RemoveStudentAction.php M includes/actions/RestoreAction.php M includes/actions/UndeleteAction.php M includes/actions/UndoAction.php M includes/actions/ViewAction.php M includes/actions/ViewCourseAction.php M includes/actions/ViewOrgAction.php M includes/api/ApiAddStudents.php M includes/api/ApiDeleteEducation.php M includes/api/ApiEnlist.php M includes/api/ApiListStudents.php M includes/api/ApiRefreshEducation.php M includes/notifications/CourseTalkNotification.php M includes/notifications/NotificationsManager.php M includes/notifications/PresentationModel/CourseTalk.php M includes/notifications/PresentationModel/RoleAdd.php M includes/notifications/RoleAddNotification.php M includes/pagers/ArticleTable.php M includes/pagers/CAPager.php M includes/pagers/CoursePager.php M includes/pagers/EPPager.php M includes/pagers/OAPager.php M includes/pagers/OrgPager.php M includes/pagers/RevisionPager.php M includes/pagers/StudentActivityPager.php M includes/pagers/StudentPager.php M includes/pages/CoursePage.php M includes/pages/EducationPage.php M includes/pages/OrgPage.php M includes/rows/CA.php M includes/rows/Course.php M includes/rows/EPArticle.php M includes/rows/EPRevision.php M includes/rows/OA.php M includes/rows/ORMRow.php M includes/rows/Org.php M includes/rows/PageObject.php M includes/rows/RevisionedObject.php M includes/rows/Student.php M includes/specials/SpecialAmbassadorProfile.php M includes/specials/SpecialCAProfile.php M includes/specials/SpecialCAs.php M includes/specials/SpecialDisenroll.php M includes/specials/SpecialEducationProgram.php M includes/specials/SpecialEnroll.php M includes/specials/SpecialInstitutions.php M includes/specials/SpecialManageCourses.php M includes/specials/SpecialMyCourses.php M includes/specials/SpecialOAProfile.php M includes/specials/SpecialOAs.php M includes/specials/SpecialStudentActivity.php M includes/specials/SpecialStudents.php M includes/specials/VerySpecialPage.php M includes/tables/CAs.php M includes/tables/Courses.php M includes/tables/Events.php M includes/tables/IORMTable.php M includes/tables/Instructors.php M includes/tables/OAs.php M includes/tables/ORMTable.php M includes/tables/Orgs.php M includes/tables/PageTable.php M includes/tables/Revisions.php M includes/tables/Students.php M maintenance/deleteEducation.php M maintenance/fixInvalidStudent.php M maintenance/fixSummaryData.php M maintenance/importWEPData.php M maintenance/importWEPFromDB.php A phpcs.xml M tests/phpunit/ActionsTest.php M tests/phpunit/ArticleAdderTest.php M tests/phpunit/ArticleStoreTest.php M tests/phpunit/CourseActivityViewTest.php M tests/phpunit/EPArticleTest.php M tests/phpunit/Events/EditEventCreatorTest.php M tests/phpunit/Events/EventGroupTest.php M tests/phpunit/Events/EventQueryTest.php M tests/phpunit/Events/EventStoreTest.php M tests/phpunit/Events/EventTest.php M tests/phpunit/Events/RecentPageEventGrouperTest.php M tests/phpunit/ExtensionTest.php M tests/phpunit/MenuTest.php M tests/phpunit/SettingsTest.php M tests/phpunit/SpecialsTest.php M tests/phpunit/Store/CourseStoreTest.php M tests/phpunit/TimelineTest.php M tests/phpunit/UPCUserCourseFinderTest.php M tests/phpunit/UserCourseFinderTest.php M tests/phpunit/UtilsTest.php M tests/phpunit/db/ORMRowTest.php M tests/phpunit/db/ORMTableTest.php M tests/phpunit/db/TestORMRowTest.php M tests/phpunit/rows/CourseTest.php M tests/phpunit/rows/OrgTest.php M tests/phpunit/rows/PageObjectTest.php M tests/phpunit/tables/OrgsTest.php 143 files changed, 2,154 insertions(+), 2,146 deletions(-) Approvals: Bartosz Dziewoński: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/333040 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I30374110e579fdb946797028cfd756a0f95add6b Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/EducationProgram Gerrit-Branch: master Gerrit-Owner: Jforrester <jforres...@wikimedia.org> Gerrit-Reviewer: AndyRussG <andrew.green...@gmail.com> Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com> Gerrit-Reviewer: Legoktm <lego...@member.fsf.org> Gerrit-Reviewer: Siebrand <siebr...@kitano.nl> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits