jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/332962 )
Change subject: ProcessResponse no longer needs to be public
......................................................................
ProcessResponse no longer needs to be public
Remove it from the public interface, mark as protected.
Change-Id: Ibde7cead7ff3b837fe7487937c734fd6a5d6a28b
---
M astropay_gateway/astropay.adapter.php
M gateway_common/GatewayType.php
M gateway_common/gateway.adapter.php
M globalcollect_gateway/globalcollect.adapter.php
M paypal_gateway/express_checkout/paypal_express.adapter.php
5 files changed, 11 insertions(+), 16 deletions(-)
Approvals:
Cdentinger: Looks good to me, approved
jenkins-bot: Verified
diff --git a/astropay_gateway/astropay.adapter.php
b/astropay_gateway/astropay.adapter.php
index fa86262..829dbfa 100644
--- a/astropay_gateway/astropay.adapter.php
+++ b/astropay_gateway/astropay.adapter.php
@@ -251,7 +251,7 @@
* params from request
* @throws ResponseProcessingException
*/
- public function processResponse( $response ) {
+ protected function processResponse( $response ) {
$this->transaction_response->setData( $response );
if ( !$response ) {
throw new ResponseProcessingException(
diff --git a/gateway_common/GatewayType.php b/gateway_common/GatewayType.php
index 31393bb..8c93558 100644
--- a/gateway_common/GatewayType.php
+++ b/gateway_common/GatewayType.php
@@ -48,17 +48,6 @@
public static function getGlobal( $varname );
/**
- * Process the API response obtained from the payment processor and set
- * properties of transaction_response
- * @param array|DomDocument $response Cleaned-up response returned from
- * @see getFormattedResponse. Type depends on
$this->getResponseType
- * @throws ResponseProcessingException with an actionable error code
and any
- * variables to retry
- */
- public function processResponse( $response );
-
-
- /**
* Perform any additional processing required when donor returns from
* payment processor site. Should set the final status.
* @param array $requestValues all GET and POST values from the request
diff --git a/gateway_common/gateway.adapter.php
b/gateway_common/gateway.adapter.php
index 67a423c..c64eb22 100644
--- a/gateway_common/gateway.adapter.php
+++ b/gateway_common/gateway.adapter.php
@@ -1450,10 +1450,16 @@
}
/**
+ * Process the API response obtained from the payment processor and set
+ * properties of transaction_response.
* Default implementation just says we got a response.
- * @param array|DomDocument $response
+ *
+ * @param array|DomDocument $response Cleaned-up response returned from
+ * @see getFormattedResponse. Type depends on
$this->getResponseType
+ * @throws ResponseProcessingException with an actionable error code
and any
+ * variables to retry
*/
- public function processResponse( $response ) {
+ protected function processResponse( $response ) {
$this->transaction_response->setCommunicationStatus( true );
}
diff --git a/globalcollect_gateway/globalcollect.adapter.php
b/globalcollect_gateway/globalcollect.adapter.php
index e54f98c..2970e7e 100644
--- a/globalcollect_gateway/globalcollect.adapter.php
+++ b/globalcollect_gateway/globalcollect.adapter.php
@@ -1271,7 +1271,7 @@
*
* @throws ResponseProcessingException with code and potentially retry
vars.
*/
- public function processResponse( $response ) {
+ protected function processResponse( $response ) {
$this->transaction_response->setCommunicationStatus(
$this->parseResponseCommunicationStatus( $response )
);
diff --git a/paypal_gateway/express_checkout/paypal_express.adapter.php
b/paypal_gateway/express_checkout/paypal_express.adapter.php
index a38a1f6..8b9965b 100644
--- a/paypal_gateway/express_checkout/paypal_express.adapter.php
+++ b/paypal_gateway/express_checkout/paypal_express.adapter.php
@@ -382,7 +382,7 @@
return true;
}
- public function processResponse( $response ) {
+ protected function processResponse( $response ) {
$this->transaction_response->setData( $response );
// FIXME: I'm not sure why we're responsible for failing the
// transaction. If not, we can omit the try/catch here.
--
To view, visit https://gerrit.wikimedia.org/r/332962
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibde7cead7ff3b837fe7487937c734fd6a5d6a28b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Ejegg <eeggles...@wikimedia.org>
Gerrit-Reviewer: AndyRussG <andrew.green...@gmail.com>
Gerrit-Reviewer: Awight <awi...@wikimedia.org>
Gerrit-Reviewer: Cdentinger <cdentin...@wikimedia.org>
Gerrit-Reviewer: Ssmith <ssm...@wikimedia.org>
Gerrit-Reviewer: XenoRyet <dkozlow...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
