Nschaaf has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/333959 )
Change subject: Fix stop iteration bug
......................................................................
Fix stop iteration bug
Change-Id: I03ba6a4677a8c31e4b974d892c7a248c1a1ec564
---
M recommendation/api/types/related_articles/candidate_finder.py
M recommendation/data/uwsgi.ini
M setup.py
3 files changed, 7 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/research/recommendation-api
refs/changes/59/333959/1
diff --git a/recommendation/api/types/related_articles/candidate_finder.py
b/recommendation/api/types/related_articles/candidate_finder.py
index 4240952..9b674a5 100644
--- a/recommendation/api/types/related_articles/candidate_finder.py
+++ b/recommendation/api/types/related_articles/candidate_finder.py
@@ -39,7 +39,11 @@
candidates = []
nearest_neighbors_iter = iter(nearest_neighbors)
while len(candidates) < count and nearest_neighbors_iter:
- chunk = itertools.islice(nearest_neighbors_iter, 500)
+ try:
+ start_of_chunk = next(nearest_neighbors_iter)
+ except StopIteration:
+ break
+ chunk = itertools.chain((start_of_chunk,),
itertools.islice(nearest_neighbors_iter, 499))
results = wikidata.get_titles_from_wikidata_items(source, (n[0] for n
in chunk))
candidates += [Candidate(title=item.title,
wikidata_id=item.id,
diff --git a/recommendation/data/uwsgi.ini b/recommendation/data/uwsgi.ini
index b3464cd..b85419a 100644
--- a/recommendation/data/uwsgi.ini
+++ b/recommendation/data/uwsgi.ini
@@ -6,3 +6,4 @@
chmod-socket = 660
vacuum = true
die-on-term = true
+harakiri = 20
diff --git a/setup.py b/setup.py
index 4e470d9..114a541 100644
--- a/setup.py
+++ b/setup.py
@@ -2,7 +2,7 @@
setup(
name='recommendation',
- version='0.1.9',
+ version='0.1.10',
url='https://github.com/wikimedia/research-recommendation-api',
license='Apache Software License',
maintainer='Wikimedia Research',
--
To view, visit https://gerrit.wikimedia.org/r/333959
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I03ba6a4677a8c31e4b974d892c7a248c1a1ec564
Gerrit-PatchSet: 1
Gerrit-Project: research/recommendation-api
Gerrit-Branch: master
Gerrit-Owner: Nschaaf <nsch...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
